mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Jhu <stanleyjhu@google.com>, HOYOUNG SEO <hy50.seo@samsung.com>
Cc: "Martin K. Petersen" <mkp@kernel.org>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	alim.akhtar@samsung.com, kwangwon.min@samsung.com,
	kwmad.kim@samsung.com, cpgs@samsung.com, h10.kim@samsung.com
Subject: Re: [PATCH v4] scsi: ufs: Change the error check sequence for auto hibern8
Date: Mon, 26 Oct 2026 08:34:03 -0700	[thread overview]
Message-ID: <1d79dd9f-ef71-43f9-a02d-5d5138047fbc@acm.org> (raw)
In-Reply-To: <18e21b71f8996bcc.3137322e31362e3131332e313435.1c875f.0000sendgmr@google.com>


On 10/26/26 7:42 AM, Stanley Jhu wrote:
> On Mon, Oct 26, 2026 at 02:26:32PM +0900, HOYOUNG SEO wrote:
>> v2: https://lore.kernel.org/linux-scsi/20261022074249.3098100-1- 
>> hy50.seo@samsung.com/
> 
>> Signed-off-by: HOYOUNG SEO <hy50.seo@samsung.com>
>> ---
> 
> Please move it above "---".
> 
>> +    if (ufshcd_is_auto_hibern8_error(hba, intr_status)) {
>> +        hba->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status);
>> +
>>       cmd = hba->active_uic_cmd;
> 
> This brace is never closed, so ufshcd.c does not build.

Hi Hoyoung,

Stanley's comments need to be addressed: please compile-test v5 and move
the Signed-off-by above "---". Additionally, please consider using a
local bool for the ufshcd_is_auto_hibern8_error() result instead of
testing hba->errors, describe the actual changes in the changelog, link
to all previous versions and Cc stable. With these addressed the
approach looks good to me.

Thanks,

Bart.

  reply	other threads:[~2026-10-26 15:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261026053046epcas2p31ae8a493f40c0f12523feec6e036072f@epcas2p3.samsung.com>
2026-10-26  5:26 ` HOYOUNG SEO
2026-10-26 14:42   ` Stanley Jhu
2026-10-26 15:34     ` Bart Van Assche [this message]
2026-10-26 17:44   ` kernel test robot
2026-10-26 18:44   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d79dd9f-ef71-43f9-a02d-5d5138047fbc@acm.org \
    --to=bvanassche@acm.org \
    --cc=alim.akhtar@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=h10.kim@samsung.com \
    --cc=hy50.seo@samsung.com \
    --cc=kwangwon.min@samsung.com \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=stanleyjhu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®