mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] nfsd: fix ino_t format specifier in nfsd_handle_dir_event tracepoint
Date: Sun, 24 May 2026 08:09:47 -0400	[thread overview]
Message-ID: <1d7dda4d0181f60362ca27c3404dc55710bca775.camel@kernel.org> (raw)
In-Reply-To: <20260523-dir-deleg-fixes-v1-4-142c884f85ce@kernel.org>

On Sat, 2026-05-23 at 12:17 -0400, Jeff Layton wrote:
> inode->i_ino is now a u64. Use the same size for the tracepoint.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/nfsd/trace.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
> index 3d0f0bd30d90..1d5d11f914f2 100644
> --- a/fs/nfsd/trace.h
> +++ b/fs/nfsd/trace.h
> @@ -1384,7 +1384,7 @@ TRACE_EVENT(nfsd_handle_dir_event,
>  	TP_STRUCT__entry(
>  		__field(u32, mask)
>  		__field(dev_t, s_dev)
> -		__field(ino_t, i_ino)
> +		__field(ino_t, u64)

My apologies. This should read:

                __field(u64, i_ino)

I had the fix in my tree and forgot to commit it before sending. Would
you like me to resend this one, or do you just want to fix it up?

>  		__string_len(name, name ? name->name : NULL,
>  				   name ? name->len : 0)
>  	),
> @@ -1394,7 +1394,7 @@ TRACE_EVENT(nfsd_handle_dir_event,
>  		__entry->i_ino = dir ? dir->i_ino : 0;
>  		__assign_str(name);
>  	),
> -	TP_printk("inode=0x%x:0x%x:0x%lx mask=%s name=%s",
> +	TP_printk("inode=0x%x:0x%x:0x%llx mask=%s name=%s",
>  			MAJOR(__entry->s_dev), MINOR(__entry->s_dev),
>  			__entry->i_ino, show_fsnotify_mask(__entry->mask),
>  			__get_str(name))

-- 
Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2026-05-24 12:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23 16:17 [PATCH 0/4] nfsd: follow-on fixes for directory delegations Jeff Layton
2026-05-23 16:17 ` [PATCH 1/4] nfsd: check for FILEID_INVALID in setup_notify_fhandle Jeff Layton
2026-05-23 16:17 ` [PATCH 2/4] nfsd: use empty string for directory name in NOTIFY4_CHANGE_DIR_ATTRS Jeff Layton
2026-05-23 16:17 ` [PATCH 3/4] nfsd: check delegation status in nfsd4_cb_notify_done Jeff Layton
2026-05-23 16:17 ` [PATCH 4/4] nfsd: fix ino_t format specifier in nfsd_handle_dir_event tracepoint Jeff Layton
2026-05-24 12:09   ` Jeff Layton [this message]
2026-05-24 17:44     ` Chuck Lever
2026-05-23 17:00 ` [PATCH 0/4] nfsd: follow-on fixes for directory delegations Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d7dda4d0181f60362ca27c3404dc55710bca775.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome