From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B87F2DF155 for ; Fri, 27 Mar 2026 13:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774619711; cv=none; b=RmLmLt5P12Jofhub/mohebZPeBd/D/ERB1zSjx670zmuSvxxJbzH2dgmOR+JfqTR0lJ1LMlbYrAlFpmyjXrStYB3YBfXzIPRKw871qmE5Y1ueyL/Gu56iaV3xpFVLCZ3gjzMS26gVnIJxFBRYApAsFmCd6M/Lx3Y5FqhGX0X/Q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774619711; c=relaxed/simple; bh=A0ASpxQP5j6PNcUBrRMq9hp9mO8JRFw0WFzXF+yIwkY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=RzOD2AquM/R0KGtJ0Lh3expk5DYe1CHfBD8YsQIFeeOX0F5ImYnTmtfA4p5FQ71B8ywo/fTshNO3I7+ouyEVuz/MvZwriYi8JLCQYJrXeFBIdmpfRHkUcWm64fZvnbHzXipRDKze3TdjfRabPXLtf77r7Ht290/qI3rW0hoQ9cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ERihMYbi; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ERihMYbi" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R7Ypla511489; Fri, 27 Mar 2026 13:54:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=io8kkQ z2kyyXwMiYjjMj7iZNgViZJRiUmp5QyNLXN3I=; b=ERihMYbibQ0WXqEGbxeWRj dMQpD65i30VWhctv4oamrkH7RlRy9uv38LdyOmwi+5kh7k+SxwKl4LI3cvgXoSc6 YQk/E9ffAd5YSK/IqyvbW9EapGwkgvxJRsBy7v1IrBz0N5AXdfPI0O/1aXf6BBF0 /UuI4rgRrgsuyNi20M0St69rI7RZlAVziRqdEoTTS9aNaNtxp4MzUXzFP+uQyhSb i+ktS5IteTgxC9cs+MvIpXPOC4T3SR0SuJEJ04p3kk1IUYqwOUEoFYms/1NqBUZA dygcEFfdAbBMcbDQMQ724+oyCMqHUtYjmmbNh4GiMCq/IGooB9nZcFbSPZ7+VrDw == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1kwaae9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Mar 2026 13:54:51 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62RBcoBW012185; Fri, 27 Mar 2026 13:54:50 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d27vkfhm2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Mar 2026 13:54:49 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62RDsml851708226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Mar 2026 13:54:48 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3275D2004B; Fri, 27 Mar 2026 13:54:48 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 32E0520043; Fri, 27 Mar 2026 13:54:46 +0000 (GMT) Received: from [9.39.30.147] (unknown [9.39.30.147]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Mar 2026 13:54:45 +0000 (GMT) Message-ID: <1d8050d1-39a7-4f6b-aa08-473cb8caf519@linux.ibm.com> Date: Fri, 27 Mar 2026 19:24:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Use sched_energy_enabled() To: Vincent Guittot References: <20260327132013.2800517-1-vincent.guittot@linaro.org> From: Shrikanth Hegde Content-Language: en-US Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, linux-kernel@vger.kernel.org In-Reply-To: <20260327132013.2800517-1-vincent.guittot@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: XgZ2zhP5tgqUThT0Kzd7TKaRPyFjN51m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA5NCBTYWx0ZWRfXwLCJUEoekNB0 lB75yz2vm366IVI1x/jMTjl3J9RWae6tujJdgwX0s8TN+DpPzwUmju4RKQUTlcJYEN4FHlXlCgS 5GhF71EpbaSeKwOa5J+XgzgwtXHI4cy9yX5qV4oflaxoscFpAMSSBrq7NHQ1DwGjvmUkgCE/6yU MOmy09GqZLaWnDxVPiNRVeP1bkv4Al4lIwTHQ0uzeAiRHkj01QhzIzfjNQmfCD47MsoKUklCm3q D7qupQWMSQRNOoJ34mMsOxt0HAQVnLsliRzLqNufaUg9b5boyTwWGNINB2ejh1tMnMMlqJgkuFh h6BngmLjZAUFXdwjvNoNSPIIWYZliW2bTAFoPGqsJC4BwfHf0QWGx2owaxXiB6B83gaBi+b9vf1 31Br6V1L+uWukdkZTCzq8dkRPfuBgdjiTyQhChhEDSokn17UMeVSn2+eCZqOCGTJw0wjMhbVd/X KSu6yoqyFJGVGfmvyCw== X-Proofpoint-GUID: 14Rp6otAy7aL606Vk-uliHmkf6z3DiF3 X-Authority-Analysis: v=2.4 cv=OsZCCi/t c=1 sm=1 tr=0 ts=69c68c2b cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=DYDuog2JwZQnLQtmXWAA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270094 On 3/27/26 6:50 PM, Vincent Guittot wrote: > Use helper sched_energy_enabled() everywhere we want to test if EAS is > enabled instead of mixing sched_energy_enabled() and direct call to > static_branch_unlikely(). > > No functional change > Makes sense. > Signed-off-by: Vincent Guittot > --- > kernel/sched/topology.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 43150591914b..5847b83d9d55 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -273,7 +273,7 @@ void rebuild_sched_domains_energy(void) > static int sched_energy_aware_handler(const struct ctl_table *table, int write, > void *buffer, size_t *lenp, loff_t *ppos) > { > - int ret, state; > + int ret; > > if (write && !capable(CAP_SYS_ADMIN)) > return -EPERM; > @@ -289,8 +289,7 @@ static int sched_energy_aware_handler(const struct ctl_table *table, int write, > > ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); > if (!ret && write) { > - state = static_branch_unlikely(&sched_energy_present); > - if (state != sysctl_sched_energy_aware) > + if (sysctl_sched_energy_aware != sched_energy_enabled()) > rebuild_sched_domains_energy(); > } > > @@ -388,11 +387,11 @@ static void destroy_perf_domain_rcu(struct rcu_head *rp) > > static void sched_energy_set(bool has_eas) > { > - if (!has_eas && static_branch_unlikely(&sched_energy_present)) { > + if (!has_eas && sched_energy_enabled()) { > if (sched_debug()) > pr_info("%s: stopping EAS\n", __func__); > static_branch_disable_cpuslocked(&sched_energy_present); > - } else if (has_eas && !static_branch_unlikely(&sched_energy_present)) { > + } else if (has_eas && !sched_energy_enabled()) { > if (sched_debug()) > pr_info("%s: starting EAS\n", __func__); > static_branch_enable_cpuslocked(&sched_energy_present); Acked-by: Shrikanth Hegde