From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABD7C433F5 for ; Fri, 25 Feb 2022 15:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241841AbiBYPOS (ORCPT ); Fri, 25 Feb 2022 10:14:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241806AbiBYPOL (ORCPT ); Fri, 25 Feb 2022 10:14:11 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E6A19141F for ; Fri, 25 Feb 2022 07:13:38 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nNcHf-0006DM-IZ; Fri, 25 Feb 2022 16:13:27 +0100 Message-ID: <1d90078d-e27f-539d-d010-78a3c4da565a@pengutronix.de> Date: Fri, 25 Feb 2022 16:13:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Ahmad Fatoum Subject: Re: [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP13 To: gabriel.fernandez@foss.st.com, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Pengutronix Kernel Team References: <20220225133137.813919-1-gabriel.fernandez@foss.st.com> <20220225133137.813919-13-gabriel.fernandez@foss.st.com> Content-Language: en-US In-Reply-To: <20220225133137.813919-13-gabriel.fernandez@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Gabriel, On 25.02.22 14:31, gabriel.fernandez@foss.st.com wrote: > From: Gabriel Fernandez > > Enable optee and SCMI clocks support. > > Signed-off-by: Gabriel Fernandez > --- > arch/arm/boot/dts/stm32mp131.dtsi | 37 +++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32mp131.dtsi b/arch/arm/boot/dts/stm32mp131.dtsi > index 262de4eeb4ed..78eac53224d4 100644 > --- a/arch/arm/boot/dts/stm32mp131.dtsi > +++ b/arch/arm/boot/dts/stm32mp131.dtsi > @@ -27,6 +27,43 @@ arm-pmu { > interrupt-parent = <&intc>; > }; > > + scmi_sram: sram@2ffff000 { > + compatible = "mmio-sram"; > + reg = <0x2ffff000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x2ffff000 0x1000>; > + > + scmi_shm: scmi_shm@0 { > + compatible = "arm,scmi-shmem"; > + reg = <0 0x80>; > + }; > + }; > + > + firmware { > + optee { > + method = "smc"; > + compatible = "linaro,optee-tz"; > + }; > + > + scmi: scmi { > + compatible = "linaro,scmi-optee"; This compatible doesn't seem to be documented upstream. I am looking at v5.17-rc5. Do you have a reference detailing the difference between this conduit and plain arm,scmi-smc (as used with TF-A on the STM32MP151). Cheers, Ahmad > + #address-cells = <1>; > + #size-cells = <0>; > + linaro,optee-channel-id = <0>; > + shmem = <&scmi_shm>; > + > + scmi_clk: protocol@14 { > + reg = <0x14>; > + #clock-cells = <1>; > + }; > + > + scmi_reset: protocol@16 { > + reg = <0x16>; > + #reset-cells = <1>; > + }; > + }; > + }; > clocks { > clk_axi: clk-axi { > #clock-cells = <0>; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |