From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753551AbdHKQZi (ORCPT ); Fri, 11 Aug 2017 12:25:38 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:17343 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbdHKQZg (ORCPT ); Fri, 11 Aug 2017 12:25:36 -0400 Subject: Re: [v6 07/15] mm: defining memblock_virt_alloc_try_nid_raw To: Michal Hocko Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-8-git-send-email-pasha.tatashin@oracle.com> <20170811123953.GI30811@dhcp22.suse.cz> <545b7230-2c09-d2f9-f26a-05ef395c36d4@oracle.com> <20170811160646.GT30811@dhcp22.suse.cz> From: Pasha Tatashin Message-ID: <1d93e0eb-080a-ed2b-de2d-092f397a981c@oracle.com> Date: Fri, 11 Aug 2017 12:24:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170811160646.GT30811@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Sure, I could do this, but as I understood from earlier Dave Miller's >> comments, we should do one logical change at a time. Hence, introduce API in >> one patch use it in another. So, this is how I tried to organize this patch >> set. Is this assumption incorrect? > > Well, it really depends. If the patch is really small then adding a new > API along with users is easier to review and backport because you have a > clear view of the usage. I believe this is the case here. But if others > feel otherwise I will not object. I will merge them. Thank you, Pasha