From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B85C01A5BA4 for ; Wed, 2 Jul 2025 08:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751446108; cv=none; b=Ng8MQpyNT/qBNPYywrN3XZi61C1MwaCoNSXqTmAQ1mVuKayVlM4XFGIVKihedjRKflP00CX77x+WCv5RRPCFqwAGt5xq4zQhf2s5UBveMliTK74yG/DQTbHRaOb1D1nKfMe4xHqyM3I9YdTwpQLm51ru2kOwF0CNPSAN+GURciY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751446108; c=relaxed/simple; bh=8Yl0z4TrZh1A/jQ3VBoWZ2eVD47pSibFyK9QHej/wug=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sRkHJ+ihp2crfT2OEaNQpA3B/gVCPoE1evQn/sWGRdjWP5ECqk45ppcy2Nu9xM5KK0jgbavuYEzR5DvnztJYE6DL9y6ShLd4kSi2JiXEl4fRFIuvSwXp/QVmM3Leshm6Ii8esy21JwJOnIzlZ+WtTUFw2kBoFqhxcgGYMLSRtkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IswaN3be; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IswaN3be" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751446105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9P/HggBDTGiN4FSKj5JuJB6QP5aE4j+fL8SIRJ5pI5U=; b=IswaN3befb5pdLCjudlhoILTtUKdH4WJudWQfj+79xiZV4oDXCPy/8PAKAICS1B6MxwDac iWm/TfmbvNtr+kky9h4UfQi3y6IPPAJn40WeoJPDsJsJMetfLWLAr9Tz6PaUHqkbKD9y62 SO2FxvRAJTOD6miBfx7iHfdysUZUHwg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-xDZ2gmZlNCGHDr8GofHMfw-1; Wed, 02 Jul 2025 04:48:24 -0400 X-MC-Unique: xDZ2gmZlNCGHDr8GofHMfw-1 X-Mimecast-MFC-AGG-ID: xDZ2gmZlNCGHDr8GofHMfw_1751446103 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45311704cdbso27865535e9.1 for ; Wed, 02 Jul 2025 01:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751446103; x=1752050903; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9P/HggBDTGiN4FSKj5JuJB6QP5aE4j+fL8SIRJ5pI5U=; b=mXOBIxC42EACpqXHAsydLD6SBUIqyQ0QMrNNELGtp1zxzgT88QD67owM40Bq4RrzqZ RxuiT4l/exMEyIX8Xl0d9C8kSlxUaMEgpdZmy4ggHVHgBehTJ3nxfBbGtEcJmCpxRegE QMiQ/WHkRHECiYU8a2CjMs+/CyBj2v5k5Q7LCE+Lx0ErHuKgHy9ue/CBKIYwWKQD9Mv+ 9eY9v3UtoRD7cwfnCW4zzy4huJ3ZZWNMTGqCKYrGyN3ZhK6P/JGyyjsL0EZ6qHnsN8Ir yiFIfWjm3YQH4C2Tj0gkMRWAUKFfrfjkX74UiGJ85xXOI7Ep/OHHe8atFQNA+Ozkj45j bD3w== X-Gm-Message-State: AOJu0YzrhMb49+Ni7J84jKDGaoEyoriymQhpOXTsuU8S2B2u72j5/IbU nuJhfk0yt+veGTcc0ZhXTfba7YSawY5mUhwVkdMglgS1TWFtylfAlt9iRHCoJhqvyk6XzgOdsx4 TRZ4ufPOFIM1INNtWCvrEmWLTBGpvsemsR7jCx7Wl3ScSsIMLpGI3BCWKODdHOH+fxw== X-Gm-Gg: ASbGncu8e9WEkRtJU5opYtySLvKN2yiFJBTzH9aNMpyxOAaE/m59WqDgBUHQ2yunxv+ NQj3+fas+BMKTkLp2EnlIm8CahbnlE22D6wBRaPauhnLvZ1CJIyzyeWj3AuOMAG2aam58amF5F5 eFdaDsxsuztkQnjIGiRREKeD7mtsu5/7rhb3oQlvqvVlvZSK+J1siNX/njcovlADyqxAHiXDNMm qmQVOylQrPqUIGxXm75Fa3SlhTNvTnRjL1ubqKoxpG9lctFsyZMoHfLStzKVyYzOd5xgr+EO4Fn u1aqvypcFDFzeqfrc/82sz+3o10LMsoM7MmIB/t+jns0a1IjEAszdBQ= X-Received: by 2002:a05:600c:3145:b0:442:faa3:fadb with SMTP id 5b1f17b1804b1-454a36d7b1emr19830765e9.2.1751446103037; Wed, 02 Jul 2025 01:48:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFr03FFkhKIjxkAApS1G8x1uv4uDWxtyu/EEYFThgeKm/UX1jbUYcebDjpAIu4pm26pt1kO8Q== X-Received: by 2002:a05:600c:3145:b0:442:faa3:fadb with SMTP id 5b1f17b1804b1-454a36d7b1emr19830415e9.2.1751446102595; Wed, 02 Jul 2025 01:48:22 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c42e1sm219717245e9.37.2025.07.02.01.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 01:48:22 -0700 (PDT) Message-ID: <1d98e96b-4bc9-45c1-9861-e0f3c5930ec2@redhat.com> Date: Wed, 2 Jul 2025 10:48:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] mm: smaller folio_pte_batch() improvements To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-3-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.07.25 10:42, Oscar Salvador wrote: > On Fri, Jun 27, 2025 at 01:55:08PM +0200, David Hildenbrand wrote: >> Let's clean up a bit: >> >> (1) No need for start_ptep vs. ptep anymore, we can simply use ptep >> >> (2) Let's switch to "unsigned int" for everything >> >> (3) We can simplify the code by leaving the pte unchanged after the >> pte_same() check. >> >> (4) Clarify that we should never exceed a single VMA; it indicates a >> problem in the caller. >> >> No functional change intended. >> >> Signed-off-by: David Hildenbrand > > Hi David :-), > > I have to confess that I fell in the same trap as Lorenzo wrt. > __pte_batch_clear_ignored changing the pte value. > So I'm not sure if it would be nice to place a little comment in > __pte_batch_clear_ignored claryfing that pte's value remains unchanged ? I mean, that's how all our pte modification functions work, really? :) Thanks! -- Cheers, David / dhildenb