From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH v2 0/6] arm64: add the time namespace support
Date: Tue, 14 Apr 2020 10:02:53 +0100 [thread overview]
Message-ID: <1d9c4c56-af16-e54f-08ca-76c6570b2d53@arm.com> (raw)
In-Reply-To: <CANaxB-xUYOrVnfLPRYVBiASzCH89sZkD6vTdy8EFjT16ZJhLfg@mail.gmail.com>
Hi Andrei,
On 4/11/20 8:33 AM, Andrei Vagin wrote:
> On Thu, Apr 9, 2020 at 6:23 AM Vincenzo Frascino
> <vincenzo.frascino@arm.com> wrote:
>>
>> Hi Andrei,
>>
[...]
>> Sorry for the delay, I completed this morning the review of your patches and I
>> do not have anymore comments on them. Thank you for making the effort and
>> bringing the time namespace support to arm64.
>
> Thank you for the review of these patches.
>
>>
>> I have though a question on something I encountered during the testing of the
>> patches: I noticed that all the tests related to CLOCK_BOOTTIME_ALARM fail on
>> arm64 (please find the results below the scissors). Is this expected?
>
> static int alarm_clock_get_timespec(clockid_t which_clock, struct
> timespec64 *tp)
> {
> struct alarm_base *base = &alarm_bases[clock2alarm(which_clock)];
>
> if (!alarmtimer_get_rtcdev())
> return -EINVAL;
>
> It is probably that you get EINVAL from here ^^^. I will send a
> separate patch to handle this case in tests properly.
>
This makes sense :) Please let me know when you post the fix so I can test it again.
Are you planning as well to rebase this set?
> Thanks,
> Andrei
>
--
Regards,
Vincenzo
next prev parent reply other threads:[~2020-04-14 9:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 7:37 Andrei Vagin
2020-02-25 7:37 ` [PATCH v2 1/6] arm64/vdso: use the fault callback to map vvar pages Andrei Vagin
2020-04-09 12:01 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 2/6] arm64/vdso: Zap vvar pages when switching to a time namespace Andrei Vagin
2020-04-09 12:01 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 3/6] arm64/vdso: Add time napespace page Andrei Vagin
2020-04-09 12:03 ` Vincenzo Frascino
2020-04-14 17:20 ` Mark Rutland
2020-04-15 2:34 ` Andrei Vagin
2020-04-15 10:05 ` Mark Rutland
2020-04-15 10:16 ` Vincenzo Frascino
2020-04-15 12:27 ` Mark Rutland
2020-02-25 7:37 ` [PATCH v2 4/6] arm64/vdso: Handle faults on timens page Andrei Vagin
2020-04-09 12:04 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 5/6] arm64/vdso: Restrict splitting VVAR VMA Andrei Vagin
2020-04-09 12:05 ` Vincenzo Frascino
2020-02-25 7:37 ` [PATCH v2 6/6] arm64: enable time namespace support Andrei Vagin
2020-04-09 12:06 ` Vincenzo Frascino
2020-04-01 6:50 ` [PATCH v2 0/6] arm64: add the " Andrei Vagin
2020-04-01 9:02 ` Vincenzo Frascino
2020-04-09 13:24 ` Vincenzo Frascino
2020-04-11 7:33 ` Andrei Vagin
2020-04-14 9:02 ` Vincenzo Frascino [this message]
2020-04-15 16:14 ` Andrei Vagin
2020-04-15 16:35 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d9c4c56-af16-e54f-08ca-76c6570b2d53@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=avagin@gmail.com \
--cc=dima@arista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®