From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751512AbeCTOm4 (ORCPT ); Tue, 20 Mar 2018 10:42:56 -0400 Received: from foss.arm.com ([217.140.101.70]:41264 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbeCTOmx (ORCPT ); Tue, 20 Mar 2018 10:42:53 -0400 Cc: Sudeep Holla , Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: scmi: use devm_of_clk_add_hw_provider() API and drop scmi_clocks_remove To: Stephen Boyd References: <1519403030-21189-17-git-send-email-sudeep.holla@arm.com> <1521547867-23808-1-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: <1d9ca586-1284-8b12-31d8-80950f29837c@arm.com> Date: Tue, 20 Mar 2018 14:42:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521547867-23808-1-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On 20/03/18 12:11, Sudeep Holla wrote: > Commit aa795c41d9cd ("clk: Add devm_of_clk_add_hw_provider()/del_provider() > APIs") adds devm_of_clk_add_hw_provider which takes care of deleting the > clock provider when the clock providers device is removed. > > This patch makes use of devm_of_clk_add_hw_provider() instead of > of_clk_add_hw_provider() so that we can eliminate the need of explicit > scmi_clocks_remove for just doing of_clk_del_provider() > > Signed-off-by: Sudeep Holla > --- > drivers/clk/clk-scmi.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > Sorry I forgot to mention before, if this looks fine, please provide ack so that I can take it via ARM Soc. -- Regards, Sudeep