From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965254AbeALVR4 (ORCPT + 1 other); Fri, 12 Jan 2018 16:17:56 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:47202 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844AbeALVRy (ORCPT ); Fri, 12 Jan 2018 16:17:54 -0500 Subject: Re: [PATCH, v3] arm: omap2: timer: fix a kmemleak caused in omap_get_timer_dt To: Tony Lindgren CC: Qi Hou , , , , , Keerthy References: <1515646483-24199-1-git-send-email-qi.hou@windriver.com> <7dd12934-862c-c7ad-5f43-43e4c6b08199@ti.com> <20180112210844.GF4821@atomide.com> From: Grygorii Strashko Message-ID: <1da42501-5a34-0e4d-68bd-1712b63174f8@ti.com> Date: Fri, 12 Jan 2018 15:17:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180112210844.GF4821@atomide.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/12/2018 03:08 PM, Tony Lindgren wrote: > * Grygorii Strashko [180112 20:36]: >> Hi >> >> On 01/10/2018 10:54 PM, Qi Hou wrote: >>> When more than one GP timers are used as kernel system timers and the >>> corresponding nodes in device-tree are marked with the same "disabled" >>> property, then the "attr" field of the property will be initialized >>> more than once as the property being added to sys file system via >>> __of_add_property_sysfs(). >>> >>> In __of_add_property_sysfs(), the "name" field of pp->attr.attr is set >>> directly to the return value of safe_name(), without taking care of >>> whether it's already a valid pointer to a memory block. If it is, its >>> old value will always be overwritten by the new one and the memory block >>> allocated before will a "ghost", then a kmemleak happened. >>> >>> That the same "disabled" property being added to different nodes of device >>> tree would cause that kind of kmemleak overhead, at leat once. >>> >>> To fix it, allocate the property dynamically, and delete static one. >> >> Does it in sync with Keerthy's work [1] > > First fixes, then new stuff! Keerthy's work will have to > wait for v4.17, we want that series sitting in Linux next > for several weeks. > Np. just want to be sure every party is aware about each other's work -- regards, -grygorii