From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 844B4C04FDF for ; Mon, 14 Aug 2023 08:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234794AbjHNIfW (ORCPT ); Mon, 14 Aug 2023 04:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234928AbjHNIfI (ORCPT ); Mon, 14 Aug 2023 04:35:08 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE04D129 for ; Mon, 14 Aug 2023 01:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692002063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BlUWJ2CnLxkuvPDb9XZkWsErKpnwhZXyja4MQxZ4sYU=; b=JirKrxZhV+javmp8K1llpmJmuev85osvk1xGICvI7mFE2fCQL3/AYM05xPlUjNIoLEezCb N6KpebQOQOBueWPg/RCr4TuTqRjULrWGCFZ6le2gsF2XjSXbb0LjsPYmga3DrZYV796zyO llSk38DPot3escuG3ihiW0qGCk7xPgw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-2zsdWxU0OUiTMpBaHXiezQ-1; Mon, 14 Aug 2023 04:34:22 -0400 X-MC-Unique: 2zsdWxU0OUiTMpBaHXiezQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-99beea69484so244424266b.0 for ; Mon, 14 Aug 2023 01:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692002061; x=1692606861; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BlUWJ2CnLxkuvPDb9XZkWsErKpnwhZXyja4MQxZ4sYU=; b=LC5EkLi3sgMP4kC69exqbaKIJan/+Xddm/9OOfoBQNanf62Ck8++VYwSkpek5IKSOv 79aCPcdVZ/ovyl7OUHj4pWFRzTiaGjXpvUkNq7aK8aQsAKyKvqpv3abQZUlJ6mYMl8QS y8E+/8YR8E6i8OrJNQGO/f+P7qsO09YR2jRfw9CDmGJALaIF4TfibTvMO1zLWIN13YiR JmN76rt0a3A+05Q/DMEyNe2ojHcxqRfe3MF1+YhBjcr10C7mqSsAFdAihXthwg/neLui mWuk1THZiOR1SQcBpZ6ytPMGeAmx9OImJ/SahSyjscvHAmdl7Q/3Qq+lwWci3XRsBa4z nttw== X-Gm-Message-State: AOJu0YxXAt6M2+56BrYZEdm2P1M6QDkBVmYV9dB/tGv+QagHD2ntkXYT plRI9a4Spc1//Xr4m9SLFg/uK2pXa2Pwv4nVBKJQOSIHKyvhKWj8yl9pd6UDt1MchX6zVciOz5z oFiKgwLzDuQJsPFMr0MJzdBSh X-Received: by 2002:a17:906:5c:b0:99c:f966:9e9f with SMTP id 28-20020a170906005c00b0099cf9669e9fmr7220364ejg.64.1692002061242; Mon, 14 Aug 2023 01:34:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlP2EFgeDt+NObU1PsrWMBNiq2nhwc54zWFCRnWTW8QfnjY0LAKVYftBpDthUIT5OBy5UPCw== X-Received: by 2002:a17:906:5c:b0:99c:f966:9e9f with SMTP id 28-20020a170906005c00b0099cf9669e9fmr7220351ejg.64.1692002060919; Mon, 14 Aug 2023 01:34:20 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a9-20020a170906190900b00992c92af6easm5419065eje.161.2023.08.14.01.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 01:34:20 -0700 (PDT) Message-ID: <1da50566-4a23-7fe4-16d2-1064f2e18a2d@redhat.com> Date: Mon, 14 Aug 2023 10:34:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] watchdog: simatic: add PCI dependency Content-Language: en-US, nl To: Arnd Bergmann , Wim Van Sebroeck , Guenter Roeck , Henning Schild Cc: "xingtong . wu" , Arnd Bergmann , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230814073924.1066390-1-arnd@kernel.org> From: Hans de Goede In-Reply-To: <20230814073924.1066390-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/14/23 09:38, Arnd Bergmann wrote: > From: Arnd Bergmann > > The simatic-ipc driver no longer depends on PCI, but its watchdog portion > still needs it, otherwise P2SB runs into a build failure: > > WARNING: unmet direct dependencies detected for P2SB > Depends on [n]: PCI [=n] && X86 [=y] > Selected by [m]: > - SIEMENS_SIMATIC_IPC_WDT [=m] && WATCHDOG [=y] && SIEMENS_SIMATIC_IPC [=y] > > drivers/platform/x86/p2sb.c:121:3: error: call to undeclared function 'pci_bus_write_config_dword'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > pci_bus_write_config_dword(bus, devfn_p2sb, P2SBC, 0); > > Add back the minimum dependendency to make it build in random configurations > again. > > Fixes: b72da71ce24b0 ("platform/x86: simatic-ipc: drop PCI runtime depends and header") > Signed-off-by: Arnd Bergmann Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 04e9b40cf7d53..09452384221a4 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -1680,7 +1680,7 @@ config NIC7018_WDT > > config SIEMENS_SIMATIC_IPC_WDT > tristate "Siemens Simatic IPC Watchdog" > - depends on SIEMENS_SIMATIC_IPC > + depends on SIEMENS_SIMATIC_IPC && PCI > default y > select WATCHDOG_CORE > select P2SB