From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BE3C7EE22 for ; Wed, 10 May 2023 12:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237013AbjEJM6n (ORCPT ); Wed, 10 May 2023 08:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229867AbjEJM6m (ORCPT ); Wed, 10 May 2023 08:58:42 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9447DDB for ; Wed, 10 May 2023 05:58:39 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bc3a2d333so10940807a12.0 for ; Wed, 10 May 2023 05:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683723518; x=1686315518; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vmcXN0ccSVxAxS0zjPv6/vv6s8isNnq9Busu1K85PKk=; b=WMugUjoI9rBvsnp5MHys4Hnmx1tFC8HDetB7UneVEMfANJ7O/X6kK87h36BUbMBUP7 G7AG+TcvqoxlJvhpXb/KsTcUam+6nN7D0AO5A+qAzV32MAg0wCzwNv0SCp5Kc6yCYiEB FcZDLk06rzwIp0/cSo7IK7D9qiJO/cJiy/eNkLSHfl0OXSYPk2KKBqoS5ZdgI1gs9Wb8 2zODctKRtxf09YaQ3bM8LfsZLMhdsZ6Do8Y4EShj2+7WkKFEpiFU7JTIG8he7s97BLXj lkHjy34TaMSHXLUIJJ4SgwmwXjSTs7s2zVmec65vJkSfw8RoNxDjescvvr1M8HPZrHVj DwGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683723518; x=1686315518; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vmcXN0ccSVxAxS0zjPv6/vv6s8isNnq9Busu1K85PKk=; b=KfuXh67eoEIn20o6jZKkN0u/GEalp+s5b2wHwHfXdA4EHtcp3lDW2QLm/p0X6wFom5 hRrS6UyBSK2iHY09CUThI7z8oOEiArp8TzbJAxxSSTf11FpN7/5+k+poUhNh2p66NFTf +iEXQ4DMy768/Y+nIcTQBcRY3d1B0+arBCHJ2xz0eo0EtY06Yx1RbRBM5/AtYZs+YBvK IBxGoJG6uHlKbMBEKC6RVK0OCqZwXMLK8l3aWWfgQK9IixFrPKNnwJNUnrOrXYFI2/Bm ++UfzPiAAQzjaeiTMkXz1oM0dfNKCUyI9qhCxb2rwNP0SjnTMZQdvvQj/O7gbUvr0PGY F2zg== X-Gm-Message-State: AC+VfDywAWvsRaKkXXJWYkQ/PkYhxbnCpgfzGjtFUaSDgdrybkurvLS6 dEw1LwvBcDi6aeXIlNLahLyaHw== X-Google-Smtp-Source: ACHHUZ7vlv2Xw5dbqTo7wtIW3Zl1dFVXIBT0zpqZpvnZwwLdMKuyidvYQtGJ5rtz/FXm54ONFcPV0A== X-Received: by 2002:a17:906:ee86:b0:962:46d7:c8fc with SMTP id wt6-20020a170906ee8600b0096246d7c8fcmr16606796ejb.21.1683723517977; Wed, 10 May 2023 05:58:37 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c175:a0f9:6928:8c9d? ([2a02:810d:15c0:828:c175:a0f9:6928:8c9d]) by smtp.gmail.com with ESMTPSA id h8-20020a1709060f4800b009600ce4fb53sm2627574ejj.37.2023.05.10.05.58.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 05:58:37 -0700 (PDT) Message-ID: <1da7fcc4-0419-e70b-afff-c010ba89e00e@linaro.org> Date: Wed, 10 May 2023 14:58:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 1/3] arm64: dts: Add device tree for the Emtop SOM IMX8MM Content-Language: en-US To: Himanshu Bhavani Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230510083231.3692247-1-himanshu.bhavani@siliconsignals.io> From: Krzysztof Kozlowski In-Reply-To: <20230510083231.3692247-1-himanshu.bhavani@siliconsignals.io> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2023 10:32, Himanshu Bhavani wrote: > Add a device tree file describing the Emtop SOM IMX8MM > > Signed-off-by: Himanshu Bhavani > --- (...) > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3 > + MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA 0x400001c3 > + >; > + }; > + > + pinctrl_pmic: pmicirq { grp suffix Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof