mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Barker <paul.barker.ct@bp.renesas.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/8] Improve GbEth performance on Renesas RZ/G2L and related SoCs
Date: Fri, 2 Feb 2024 09:39:42 +0000	[thread overview]
Message-ID: <1daa9e95-df98-4a08-bc55-21838e555519@bp.renesas.com> (raw)
In-Reply-To: <953f6b82-c4b1-43f7-af68-e504d663f070@lunn.ch>


[-- Attachment #1.1.1: Type: text/plain, Size: 1229 bytes --]

On 31/01/2024 18:26, Andrew Lunn wrote:
>> Changes are made specific to the GbEth IP, avoiding potential impact on
>> the other Renesas R-Car based SoCs which also use the ravb driver. This
>> follows the principle of only submitting patches that we can fully test.
>  
> Are you saying that Renesas does not have access to all Renesas RDKs?
> 
> I don't particularly like the way your first patch makes a copy of
> shared functions. Is it not likely that R-Car would also benefit from
> this?

We have the required RDKs. For the R-Car based SoCs, we need to confirm
that gPTP still works if we change the poll/receive code paths - this
will require an AVB-capable network switch and additional time to test.
So our plan was to handle the GbEth code paths first without affecting
R-Car, then follow up with another patch set for the R-Car code paths
when we've done the required tests.

I discussed this with our team, and we're happy to do this in one go for
both R-Car and GbEth code paths if that's preferred. I'll send the
patches as an RFC (as Sergey has commented it should be an RFC anyway as
it depends on an unmerged patch) and we'll do the gPTP test with a
couple of R-Car boards.

Thanks,
Paul

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3577 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  reply	other threads:[~2024-02-02  9:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 17:05 Paul Barker
2024-01-31 17:05 ` [PATCH net-next 1/8] net: ravb: Split R-Car & GbEth poll functions Paul Barker
2024-01-31 17:05 ` [PATCH net-next 2/8] net: ravb: Simplify GbEth poll & receive functions Paul Barker
2024-01-31 17:05 ` [PATCH net-next 3/8] net: ravb: Count packets in GbEth RX (not descriptors) Paul Barker
2024-01-31 17:05 ` [PATCH net-next 4/8] net: ravb: Always process TX descriptor ring in GbEth poll Paul Barker
2024-01-31 17:05 ` [PATCH net-next 5/8] net: ravb: Always update error counters Paul Barker
2024-01-31 17:05 ` [PATCH net-next 6/8] net: ravb: Align GbEth poll function with NAPI docs Paul Barker
2024-01-31 17:05 ` [PATCH net-next 7/8] net: ravb: Enable SW IRQ Coalescing for GbEth Paul Barker
2024-01-31 17:05 ` [PATCH net-next 8/8] net: ravb: Use NAPI threaded mode on 1-core CPUs with GbEth IP Paul Barker
2024-01-31 18:26 ` [PATCH net-next 0/8] Improve GbEth performance on Renesas RZ/G2L and related SoCs Andrew Lunn
2024-02-02  9:39   ` Paul Barker [this message]
2024-02-02 13:30     ` Andrew Lunn
2024-02-01 19:22 ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1daa9e95-df98-4a08-bc55-21838e555519@bp.renesas.com \
    --to=paul.barker.ct@bp.renesas.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=s.shtylyov@omp.ru \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®