From: Michal Luczaj <mhal@rbox.co>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Arseniy Krasnov <avkrasnov@salutedevices.com>,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] vsock: Make accept()ed sockets use custom setsockopt()
Date: Mon, 29 Dec 2025 20:45:09 +0100 [thread overview]
Message-ID: <1dad1adc-f287-4871-a86d-e77fe7f84b89@rbox.co> (raw)
In-Reply-To: <aUqI_qW3SZ-WBXk3@sgarzare-redhat>
On 12/23/25 14:15, Stefano Garzarella wrote:
> On Tue, Dec 23, 2025 at 12:09:51PM +0100, Michal Luczaj wrote:
>> On 12/23/25 11:26, Stefano Garzarella wrote:
>>> On Tue, Dec 23, 2025 at 10:15:28AM +0100, Michal Luczaj wrote:
>> ...
>>>> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
>>>> index adcba1b7bf74..c093db8fec2d 100644
>>>> --- a/net/vmw_vsock/af_vsock.c
>>>> +++ b/net/vmw_vsock/af_vsock.c
>>>> @@ -1787,6 +1787,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock,
>>>> } else {
>>>> newsock->state = SS_CONNECTED;
>>>> sock_graft(connected, newsock);
>>>> + set_bit(SOCK_CUSTOM_SOCKOPT, &newsock->flags);
>>>
>>> I was a bit confused about next lines calling set_bit on
>>> `connected->sk_socket->flags`, but after `sock_graft(connected,
>>> newsock)` they are equivalent.
>>>
>>> So, maybe I would move the new line before the sock_graft() call or use
>>> `connected->sk_socket->flags` if you want to keep it after it.
>> ...
>>>> if (vsock_msgzerocopy_allow(vconnected->transport))
>>>> set_bit(SOCK_SUPPORT_ZC,
>>>> &connected->sk_socket->flags);
>>
>> Hmm, isn't using both `connected->sk_socket->flags` and `newsock->flags` a
>> bit confusing?
>
> Yep, for that reason I suggested to use `connected->sk_socket->flags`.
>
>> `connected->sk_socket->flags` feels unnecessary long to me.
>> So how about a not-so-minimal-patch to have
>>
>> newsock->state = SS_CONNECTED;
>> set_bit(SOCK_CUSTOM_SOCKOPT, &newsock->flags);
>> if (vsock_msgzerocopy_allow(vconnected->transport))
>> set_bit(SOCK_SUPPORT_ZC, &newsock->flags);
>> sock_graft(connected, newsock);
>
> No, please, this is a fix, so let's touch less as possible.
>
> As I mentioned before, we have 2 options IMO:
> 1. use `set_bit(SOCK_CUSTOM_SOCKOPT, &newsock->flags);` but move it
> before `sock_graft()`
> 2. use `connected->sk_socket->flags` and set it after `sock_graft()` if
> we want to be a bit more consistent
>
> I'd go with option 2, because I like to be consistent and it's less
> confusing IMHO, but I'm fine also with option 1.
Yeah, all right, here it is:
https://lore.kernel.org/netdev/20251229-vsock-child-sock-custom-sockopt-v2-0-64778d6c4f88@rbox.co/
Thanks,
Michal
next prev parent reply other threads:[~2025-12-29 19:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 9:15 [PATCH net 0/2] vsock: Fix SO_ZEROCOPY on accept()ed vsocks Michal Luczaj
2025-12-23 9:15 ` [PATCH net 1/2] vsock: Make accept()ed sockets use custom setsockopt() Michal Luczaj
2025-12-23 10:26 ` Stefano Garzarella
2025-12-23 11:09 ` Michal Luczaj
2025-12-23 13:15 ` Stefano Garzarella
2025-12-29 19:45 ` Michal Luczaj [this message]
2025-12-23 9:15 ` [PATCH net 2/2] vsock/test: Test setting SO_ZEROCOPY on accept()ed socket Michal Luczaj
2025-12-23 10:27 ` Stefano Garzarella
2025-12-23 11:10 ` Michal Luczaj
2025-12-23 13:20 ` Stefano Garzarella
2025-12-23 16:50 ` Stefano Garzarella
2025-12-23 20:38 ` Michal Luczaj
2025-12-24 9:15 ` Stefano Garzarella
2025-12-29 19:40 ` Michal Luczaj
2026-01-07 10:53 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dad1adc-f287-4871-a86d-e77fe7f84b89@rbox.co \
--to=mhal@rbox.co \
--cc=avkrasnov@salutedevices.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®