From: David Laight <David.Laight@ACULAB.COM>
To: "'Gustavo A. R. Silva'" <gustavo@embeddedor.com>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: RE: [PATCH] usbip: vhci_hcd: Mark expected switch fall-through
Date: Mon, 29 Apr 2019 14:44:27 +0000 [thread overview]
Message-ID: <1daec8c8929e4d18b2059ab1dfbfdf4a@AcuMS.aculab.com> (raw)
In-Reply-To: <20190429143957.GA6725@embeddedor>
From: Gustavo A. R. Silva
> Sent: 29 April 2019 15:40
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
...
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 667d9c0ec905..000ab7225717 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -508,6 +508,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> case USB_PORT_FEAT_U1_TIMEOUT:
> usbip_dbg_vhci_rh(
> " SetPortFeature: USB_PORT_FEAT_U1_TIMEOUT\n");
> + /* Fall through */
> case USB_PORT_FEAT_U2_TIMEOUT:
> usbip_dbg_vhci_rh(
> " SetPortFeature: USB_PORT_FEAT_U2_TIMEOUT\n");
That doesn't look right, both debug messages seem to get printed.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-04-29 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:39 Gustavo A. R. Silva
2019-04-29 14:44 ` David Laight [this message]
2019-04-29 15:05 ` Gustavo A. R. Silva
2019-04-29 15:34 ` David Laight
2019-04-30 15:44 ` Greg Kroah-Hartman
2019-04-30 15:49 ` shuah
2019-04-30 17:38 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1daec8c8929e4d18b2059ab1dfbfdf4a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®