From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Diederik de Haas" <didi.debian@cknow.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Jassi Brar" <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-team@android.com, willmcvicker@google.com,
peter.griffin@linaro.org, daniel.lezcano@linaro.org,
vincent.guittot@linaro.org, ulf.hansson@linaro.org,
arnd@arndb.de,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v8 1/3] dt-bindings: firmware: add google,gs101-acpm-ipc
Date: Tue, 11 Feb 2025 13:29:09 +0000 [thread overview]
Message-ID: <1daff001-4769-4aeb-83a6-dafbe84fb39b@linaro.org> (raw)
In-Reply-To: <e2bdc9aa-2cbb-4fcc-8c73-5fcdad6e18a7@kernel.org>
On 2/11/25 12:05 PM, Krzysztof Kozlowski wrote:
> On 11/02/2025 13:02, André Draszik wrote:
>> Hi Tudor,
>>
>> On Tue, 2025-02-11 at 11:57 +0000, Tudor Ambarus wrote:
>>> And then I shall s/MODULE_LICENSE("GPL");/MODULE_LICENSE("GPL v2");/
>>> everywhere as "GPL" indicates [GNU Public License v2 or later].
>>
>> No, please don't, see Documentation/process/license-rules.rst.
Indeed, thanks, Andre'! The tag shouldn't convey the detailed license
information, as the only decision to be made is whether the module is
free software or not. I'll keep MODULE_LICENSE("GPL");
> For the rest of suggestions here I also recommend rereading docs. I
always a good suggestion :)
> don't get why we need to change "GPL-2.0 OR BSD-2-Clause", but maybe I
I reread the docs, LICENSES/preferred/GPL-2.0 says that:
'''
For 'GNU General Public License (GPL) version 2 only' use:
SPDX-License-Identifier: GPL-2.0
or
SPDX-License-Identifier: GPL-2.0-only
```
the two are equivalent. The downstream driver uses "GPL-2.0-only". I
think it'd be good that everything that I derived from it to have the
same SPDX value, for consistency reasons.
Thus I'll amend the license on the bindings file and on
include/linux/firmware/samsung/exynos-acpm-protocol.h only.
I'm not thrilled about a new version for such a small change, but I
think it's worth it.
Thanks,
ta
next prev parent reply other threads:[~2025-02-11 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 8:52 [PATCH v8 0/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2025-02-11 8:52 ` [PATCH v8 1/3] dt-bindings: firmware: add google,gs101-acpm-ipc Tudor Ambarus
2025-02-11 10:36 ` Diederik de Haas
2025-02-11 11:57 ` Tudor Ambarus
2025-02-11 12:02 ` André Draszik
2025-02-11 12:05 ` Krzysztof Kozlowski
2025-02-11 13:29 ` Tudor Ambarus [this message]
2025-02-11 13:29 ` Diederik de Haas
2025-02-11 15:06 ` Krzysztof Kozlowski
2025-02-11 8:52 ` [PATCH v8 2/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2025-02-11 8:52 ` [PATCH v8 3/3] MAINTAINERS: add entry for the Samsung Exynos ACPM mailbox protocol Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1daff001-4769-4aeb-83a6-dafbe84fb39b@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®