From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbeEOWSB (ORCPT ); Tue, 15 May 2018 18:18:01 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37425 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbeEOWSA (ORCPT ); Tue, 15 May 2018 18:18:00 -0400 X-Google-Smtp-Source: AB8JxZokIuaS3ndmgZN8e6F6urjDkGJG28Z5mVtMF+VHxpiiQVHPC++ha8/MpE+cxVJylygzOK9KcA== Subject: Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256 To: Radu Pirea , Boris Brezillon Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Zhiqiang.Hou@nxp.com, pp@emlix.com, richard@nod.at, computersforpeace@gmail.com, dwmw2@infradead.org References: <20180504155404.5285-1-radu.pirea@microchip.com> <20180504204013.254d90cf@bbrezillon> From: Marek Vasut Message-ID: <1db092c8-95fb-5747-f7b9-f6a215b1aa5b@gmail.com> Date: Wed, 16 May 2018 00:17:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15/2018 06:22 PM, Radu Pirea wrote: > On Fri, 2018-05-04 at 20:40 +0200, Boris Brezillon wrote: >> On Fri, 4 May 2018 18:54:04 +0300 >> Radu Pirea wrote: >> >>> Added geometry description for Microchip 25LC256 memory. >> >> Same as for the dataflash stuff you posted a few weeks ago: I don't >> think this device belongs in the SPI NOR framework. > Hi Boris, > > 25lc256 memory is similar with mr25h256, the only difference is the > page size(64 vs 256). Because mr25h256 is already in SPI NOR framework > I added here 25lc256. I think I must be reading the wrong datasheet, but can you show me how does it support things like READID opcode ? -- Best regards, Marek Vasut