From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364E21DF246 for ; Mon, 20 Jan 2025 10:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737368052; cv=none; b=VxVsjM0JNv4iZxGbfuWzvKu/OGS4q3C+NmWPhQK7pRQVUHzYyJKavHoPEHDAJYV2MjAy8Z9jAxRmGYst/6QS2zFV0wDEPPPUqSMaJjFYTKrovM2lir2GuCZQyEeSZWTBq1OXVMdl/x0gfUVKuASeLI87piUujRw/1jxOSd7LCR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737368052; c=relaxed/simple; bh=tmLPNb0QjV0neePXR0TLKSlDtDzLuSdeonr4XEPD5Cg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N1i4Eweh6jQY9H1a+iPWpBFN2drvl8XJqEEZ2IoTZOvsk5sN1FHwQ7wr2Wc+3Gk2MHWi5BtOgwzEj2+xAIm/NXyY9L8NRd6DN2aS5RWBDKJxriHKxvzaSmR3TUguHeKrqQiKbSgc7eoWKc5TrdHBHdrJvbqiGSRNcOs1M5ADaMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LjhT6btr; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LjhT6btr" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3862d161947so2251696f8f.3 for ; Mon, 20 Jan 2025 02:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737368048; x=1737972848; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kYfPY3uHWPDRjBBvUAyHNjZ+LPl2Pcpq4JSbzBPDOM8=; b=LjhT6btriFAorbJ4smgiofMymFz2J0VDEFf1UGMldnPzsCbbjWuYe3SrpK7ztYnxaH Z/rDvsUSdxj92Wr2ZPs+zf3289hh5/INYQdo08QtPFc+4jXnN44xODOpCVplbr/xOCxY gb7uI2uR9XiaQF2/VM+PFtKgyDq/va+wRtNidgZo5LL0HN1tqXci4Ca9HG6iUyi2Ggbb hSTJw0clQSCKnJk+wfrFO+BLhCKMzuMNsNiTsBrGvVovcZ9jlEmfIaM9J4fdY0xrfDxN s8sZQB1VMeY+65MM86n84Go89i6FgXbOByE+jyZ93+Wgu2ioPnlGIBMeVoj77BHRkIe2 Mvsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737368048; x=1737972848; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kYfPY3uHWPDRjBBvUAyHNjZ+LPl2Pcpq4JSbzBPDOM8=; b=mP3pzkxDTaRf4IFdI3elb+73kX4sQrs0q6xHwaINSmwXQ+BGM5VTmRTiFNO6u0puDC /W+mnEZoxQkMHTVXw3/SyYMJfOQ7whi+QwQ3i8IHFkcdD7a02//eE38oKyyf+420F0DZ MeVlIJQR83cVaK2Lnnk5BxH1Aa6Dsb9Fy8gxilM6Kywmm5HpHAcGsj864cdGBC9S8/Lg 7VY8+DvA6n2IueV5Y+hGwPancDefBCC/n+dPJmQcjCs+t3cUaT8O+hsTFDKCVMhcvwDK 44UrFyRiaXR4awBUD9ndZNIJ5+4dOZJGIRV7H7am25QJLA2/KC1j6nbX0sFlmiDynuJE HHyg== X-Forwarded-Encrypted: i=1; AJvYcCVq4Gwl1vZ/i4oKJvPQqXm7sg0koCj0cYlTQHJRI7qqWmhy/DTUs45lE5a7rLqzTLOeGmrXE8Xr69IXRwQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzrG35po/i7pvDf5qEl86mtss2v1/MY7eBrdKj7mVkdxcCeyznA EN/jU3yYNnBj8gQaClW2okq/7idhN2C3bREP/ViEdL+sJE6J/u/P/6EVupW3CRk= X-Gm-Gg: ASbGncsGm1C5toOVhPCTXKqSum0TZAX72HWbgdyjNOhD4P4OKRi7+DbKVsNxdEj8BJk +ksIMTidQYTO9duHPA4EcWiLqf+dm3qkW7ngOUe0TPmvijYpaEjtpdpJiq7vm6a2V/Bg+RkaGiZ mICvjXgv2LRRZG6QG5lx3eCj8OnCJ6pvY8InJLChIIOSKWUHH8WULaEAcnWYZRSCoX+QvO0P+wp GBA+bM/TK00KJeNsLefXLdkW8+8b7zGegY2VZripDCF4TR9nAd2KMNCAvtpbZ2yVFtZCmYJRMes 3w0V X-Google-Smtp-Source: AGHT+IE7vzlr91GTWyVQ2uFuiGjH2pXvFzm6Et3XtZumjCMhoeA+okGxgS/WDqvFvtDygaCrq/tOqQ== X-Received: by 2002:a5d:6c63:0:b0:385:fdc2:1808 with SMTP id ffacd0b85a97d-38bf57a65b6mr12761968f8f.40.1737368047070; Mon, 20 Jan 2025 02:14:07 -0800 (PST) Received: from [192.168.68.163] ([212.105.145.45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3275755sm9797579f8f.80.2025.01.20.02.14.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 02:14:06 -0800 (PST) Message-ID: <1db0c4db-5e63-46f3-9bb9-898cb8312aae@linaro.org> Date: Mon, 20 Jan 2025 10:14:04 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] perf vendor events arm64: Add N3 events/metrics To: Namhyung Kim , Ian Rogers Cc: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Nick Forrington References: <20250110172006.680753-1-irogers@google.com> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/01/2025 6:22 pm, Namhyung Kim wrote: > Hello, > > On Mon, Jan 13, 2025 at 04:48:06PM +0000, James Clark wrote: >> >> >> On 13/01/2025 3:51 pm, Ian Rogers wrote: >>> On Mon, Jan 13, 2025 at 4:35 AM James Clark wrote: >>>> >>>> >>>> >>>> On 10/01/2025 5:20 pm, Ian Rogers wrote: >>>>> Using the scripts at: >>>>> https://gitlab.arm.com/telemetry-solution/telemetry-solution/ >>>>> >>>>> Generate perf json for neoverse-n3 using the following command: >>>>> ``` >>>>> $ telemetry-solution/tools/perf_json_generator/generate.py \ >>>>> tools/perf/ --telemetry-files \ >>>>> telemetry-solution/data/pmu/cpu/neoverse/neoverse-n3.json:neoverse-n3 >>>>> ``` >>>>> >>>>> Signed-off-by: Ian Rogers >>>>> --- >>>>> .../arm64/arm/neoverse-n3/core-imp-def.json | 930 ++++++++++++++++++ >>>> >>>> I assume you got warnings about missing groups, if one is missing that >>>> results in everything being dumped in core-imp-def.json. I have an >>>> internal ticket open about it which is why I didn't post N3 and V3 jsons >>>> yet, I'll check on it again. >>> >>> I was testing with JEVENTS_ARCH=all. I'm not sure what the group >>> warning is, do you have a link? >>> >> >> From the perf_json_generator: >> >> $ telemetry-solution/tools/perf_json_generator/generate.py \ >> tools/perf/ --telemetry-files \ >> telemetry-solution/data/pmu/cpu/neoverse/neoverse-n3.json:neoverse-n3 >> >> Warning: Not writing events which do not have a group (note that the >> mnemonic printed may differ to the one in the source json if it differs >> in the common Perf files): >> >> IMP_CT_FLUSH: Counts flushes including architectural, >> microarchitectural, and branch redirects. >> ... >> >>>> Up to you whether you want to continue with it like this and I can send >>>> a fix up later but there's also a conflict with the recent Fujitsu >>>> Monaka events. >>> >>> I'm happy to let you push the updates. An alternative, that may work >>> around the group issue, is just to push the event updates. Any chance >>> on an ETA? >>> >>> Thanks, >>> Ian >> >> Can't say on an eta. There was a fix already done but not made live yet, but >> now it turns out maybe we don't want to put these particular events into >> Perf because they're not in the TRM. Could be several weeks before anything >> goes live. >> >> It's a bit of a hack but I can regenerate them without these particular >> events in a V2, and then whatever the outcome is from above will be an >> incremental change later. > > So what's the final decision? > > James, do you want to publish the metrics later at once or are you ok > with this patch for now (and do the incremental change later)? > > Thanks, > Namhyung > I'm just finishing off some changes to the generator script and the change will end up a bit different. Turns out it wasn't updating the common events properly either. I think it's best to leave this one out and I'll send a v2 this week.