From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF8D134846A for ; Fri, 3 Jul 2026 08:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783067149; cv=none; b=Ncf9bvv4hLj1HSX77uESckjByhyltfrhFIluwWW7zX/GqN7z24Itd9xBUu/36dFXMXhpGMaEwmciLtAQ7hTMbmTsEj2YNDvXHDcF5+PnyaDT+7NgZj+mLxnNiMu8jwbb9Ih5MCWtZMXmngHC0vik21mri1o9nEKPxMb+8FAXwd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783067149; c=relaxed/simple; bh=Z3lhZcvTy3ChvwrsZwjryfnqt63yUqro+E8ba0wENaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j3bUl2Ejx1yuZjVWd4MKwxP85CqnxoCdgNMyfUDrGkeFjinKuNRBdaTyTbJwpRj5GNfUAomqbyjqjRFKC4QASu4g3v6yxXaXGgeEnOf78lfCnAWNSWbxKDr2c8R0YYYWmIfo5vhzpKGNWYiRtmeZNA+T1Mcm/oFgQxfkBx0KP8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aOmQVJto; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Zce1hbjX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aOmQVJto"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Zce1hbjX" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6635rfI42994867 for ; Fri, 3 Jul 2026 08:25:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= muNeEPc2vpjuOsLjLd4zSCfTUU2sqAB/F6JbZI/i5BY=; b=aOmQVJto31isSbl/ qfWSCSG3v4pXIhUSvwVqonp8Bmz1j9cuRdqmxS4psUVlFW0PRqBPDaM3gKX2xnh1 Wy3Yk3C7HIjgzWSiY6YXXWFtvnbEesF0tpihjutQH59EGOpmK7j0ogvneiwDaRAK APiOWv5eTiehuu4PnsctkDnksfjoqs7m8HKb6blH9VtjtI+hGZBziym1ZU2drAI2 UFD1VJAtNkR0M4IRQtfJc0mJs9w/OpELHDBXv/6uMssVVNryTpuiW0FTR5Gff0gY GBNWRDn6daL/UbZFWP6w05ryR2JNjRCcxmoO58LgXn62glh2mI5TaFoE+RE5P8VD lSvMwg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f648n1eeb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 08:25:46 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36d97a4e08fso718681a91.0 for ; Fri, 03 Jul 2026 01:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783067146; x=1783671946; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=muNeEPc2vpjuOsLjLd4zSCfTUU2sqAB/F6JbZI/i5BY=; b=Zce1hbjXCA8VTFqoCjM8EHBL7oSKg5qkOkevTipnjilzL0Ak3b7EUOX7pD+mGC3TVc uXHrKWT1QettroPB2CyPTpuOaNfteTdOvgRgZ5gLWZZ7x0tNoHzvh+dwNlPn0KpgEE48 a0zW7WsKQ8GwXpkqaMQc5VQakt6aLz/2M5+U2qkpYWH9ZqtSVR8f63NqrqtU2K6DRhTB sBgzVWUKYSIkf+BJjNPDAQwB4ke/R2RMRL37lDF2gDL4H1u6Totrrh10tasU+EVtcUQ+ 6YxOkQAyL8xist1nP/fEZe3KP9RDjrZX5SdLZH2QdqfGh3QKyC6rqJzJSYWPJu6ztjHp LA9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783067146; x=1783671946; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=muNeEPc2vpjuOsLjLd4zSCfTUU2sqAB/F6JbZI/i5BY=; b=cgGUFLSQQNCy7iDHeSWGDZmNtmoLWY/tDQF5cWuY0IKsHSDF2WqoVdB21Kw3+vpWkF 4q5LhQ22XvFZehDHkFSQOYFHoyBOixaxPATSmvC75G8NO009dakja37ZjS5i5hD9JD2l 4/aVndy3X9VPEuEcdQ0lQ9AIlq9B6MxJkcXe+Gss1dxZLKbtv5TaowZFeUMeTttnnQQB fMsodp/52++K9cllvj+8g1k0CEu9Fam0h8tQOh/PqZzlQZGntGjmQ+zRKOPr5Trj4Q7L n85f0582WN6T8myknFpQ5aWKXxaVr0YAui1HiHYtE+f4RyMr/hHdrVvbm119qtiT6Aib zzUg== X-Forwarded-Encrypted: i=1; AHgh+Rp+Io9nN+agSoYPwoY8fgaX1Rfp3/SbKclA+n3UNdXOQqDYiR0DJWnVvQKX5HOUBG4C193Cm8W69SXsmes=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf+v3lWBSbtiQmnHVbiQQUZGQeO1AEEuwo86IoxZGnhXuvhe6e SHNmQld27wNQOeQdszdh54evd72jnLVJYpvm2eoSugALJk0HOcJnM/BI+48MH6qYR19qPe/SeDB 9SwhWV9j+W238mEL7XxO/ocwxQGEVXkeF1qr/MhtbKq+uGp6GV3e9S3NWhOK51LLEvCc= X-Gm-Gg: AfdE7ckOUIehAbK3oRvmFI2ZyhXmm+eV9mRxghhf9MS3JJDw3kW+9sd1p5tiMQ3+odE kGMCkiPyRGHMKSJloigRvhQWtNQTqAewmlaBSgAwgaiJwCJVa7Mj9s4irME+o31isqrll1KRhc8 eAVLLJDBbkgFlLGIFQlJYMactVWsXglmVr0rCqeGzUJEWkRAtnZ78RfzAOcn9OBZHPg2twp0O3i NxfZ8fFOgEceuq3wqcMe1+yiXphilSzuLhwMZlqahQtfewAks6EPiIIYwI2SG1h+GfqYLoIhNpl 3Siu8Gx6zuZqliLLwSW/qAPp3cmoqeXpmFxeZnHBfImN4Jys8kxMJIZ/Xf4iDjEzu3YBwY3D0bB BOfKz9mM70M4WxZnaehmmT9ZL6SmtNjwSromnX8Os9+o= X-Received: by 2002:a17:90b:528b:b0:381:3b5d:30f4 with SMTP id 98e67ed59e1d1-3813b5d35f1mr1237817a91.1.1783067145694; Fri, 03 Jul 2026 01:25:45 -0700 (PDT) X-Received: by 2002:a17:90b:528b:b0:381:3b5d:30f4 with SMTP id 98e67ed59e1d1-3813b5d35f1mr1237775a91.1.1783067144955; Fri, 03 Jul 2026 01:25:44 -0700 (PDT) Received: from [10.217.222.146] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b816a42sm30312280eec.9.2026.07.03.01.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 01:25:44 -0700 (PDT) Message-ID: <1db1de13-385e-4b9e-b18f-f7035f1b58f5@oss.qualcomm.com> Date: Fri, 3 Jul 2026 13:55:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: crypto: qcom,inline-crypto-engine: Fix legacy/new SoC strictness split To: Krzysztof Kozlowski Cc: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Harshal Dev , Vinod Koul , Bartosz Golaszewski , Konrad Dybcio , Frank Li , Andy Gross , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org References: <20260702-b4-shikra_crypto_changse-v2-0-66173f2f28b3@qti.qualcomm.com> <20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@qti.qualcomm.com> <20260703-nice-beetle-of-efficiency-eafad3@quoll> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260703-nice-beetle-of-efficiency-eafad3@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDA3OSBTYWx0ZWRfXzcbpHLeaAT1Q rB/gAF1so9Gm4pw8stUNxCx2wax/zKYsvSdEuczhKoONSaIppIoK/Pt441UuF+drRXqL6mVzlG7 GFCnLXSZqkLAaLQuaeIPPz9hA+rbraA= X-Proofpoint-ORIG-GUID: G5imb4sJ8ROmASs48QOa2o-KisyXJRDr X-Authority-Analysis: v=2.4 cv=O4wJeh9W c=1 sm=1 tr=0 ts=6a47720a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=QthcfW-pFkhp4WIqV0YA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: G5imb4sJ8ROmASs48QOa2o-KisyXJRDr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDA3OSBTYWx0ZWRfXxXggoR6jA1u9 P7rY7rD9dk9G7EbAWpLbEGchmidHPugJ/6vHSbq5XjoumeTjDECssHhBEja0qx2bUOB3U45SjxI jA+m0r1eChK8211M3gav/46+DvEloeQ4ALPq1b2nnG6vKC7YiIWM7qIe8ae4zYlJeC0R9Y7INk0 y7JtXv+Fda5/WUTvv6tMOSjd+NOiyZaC/mICwEOaiI3B6PF/2dpykNhbnDzz5QyZQAtAf4E7v5l MA8rrX8/ZmdcAhrcLWMBoa0u9XhKMS5FSWyEBwc207RxUSmcmVPP16x/ClZ+TOf0DSW7d82BgI0 EepKoJCbTARrrO9VSkycbs8pDNmH653hGNyDa4KUkin4FNUT5qxUy/cpRtHeTjKC8Oz7sH49ptS 03x4xAORCQ8cazE8806WR1pwCLwXNePYQI4Munnfd5sbRArV5T4e6MzvQjwSnM6gVo0C3tVGtPp BBFOy5hlA1R5yqHAjXg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030079 On 03-07-2026 12:21, Krzysztof Kozlowski wrote: > On Thu, Jul 02, 2026 at 01:47:11AM +0530, Kuldeep Singh wrote: >> Couple of already merged SoCs describe ICE as single clock historically >> which are recently updated with mandatory 2 clocks. >> >> Keep only the known legacy compatibles flexible, and make strict >> validation default(of power-domains and 2 clocks) for all other Soc >> compatibles. >> >> This ensures old DTs are valid while ensuring any new SoC (not in the >> legacy allowlist) must follow latest requirements by default. >> >> Fixes: e27264daac7d ("dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk") > > Please drop, original codeo was correct, no bug to fix. Ok. > >> Signed-off-by: Kuldeep Singh >> --- >> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 23 ++++++++++++++++------ >> 1 file changed, 17 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> index db895c50e2d2..4f3689a24410 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> @@ -55,14 +55,25 @@ required: >> >> additionalProperties: false >> >> +# Do not extend the list. >> +# Legacy SoCs are allowed for single clock. >> +# New SoCs must provide both clocks and power domains. >> allOf: >> - if: >> - properties: >> - compatible: >> - contains: >> - enum: >> - - qcom,eliza-inline-crypto-engine >> - - qcom,milos-inline-crypto-engine >> + not: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,kaanapali-inline-crypto-engine > > Your change is not equivalent in relation to hawi. Please make it > explicit in commit msg - all devices which are fixed by this. Sure, eliza/milos/hawi are non-legacy and will adapt 2 clocks model by default so will update them in commit message. -- Regards Kuldeep