From: Matthias Brugger <matthias.bgg@gmail.com>
To: Gene Chen <gene.chen.richtek@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com
Subject: Re: [PATCH] mfd: mt6360: Fix register driver NULL pointer by add driver name
Date: Tue, 9 Jun 2020 14:01:19 +0200 [thread overview]
Message-ID: <1db40ad0-faf4-2a4a-8514-fed59d5053f7@gmail.com> (raw)
In-Reply-To: <CAE+NS36mxw-FpQhJ4qV=_+r2CXVi_PaGaZo2m3jXAGFuOO252Q@mail.gmail.com>
On 09/06/2020 13:43, Gene Chen wrote:
> Lee Jones <lee.jones@linaro.org> 於 2020年6月9日 週二 上午3:28寫道：
>>
>> On Mon, 08 Jun 2020, Gene Chen wrote:
>>
>>> From: Gene Chen <gene_chen@richtek.com>
>>>
>>> accidentally remove driver name when
>>> replace probe by probe_new in add mt6360 mfd driver patch v4
>>>
>>> [ 121.243012] EAX: c2a8bc64 EBX: 00000000 ECX: 00000000 EDX: 00000000
>>> [ 121.243012] ESI: c2a8bc79 EDI: 00000000 EBP: e54bdea8 ESP: e54bdea0
>>> [ 121.243012] DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068 EFLAGS: 00010286
>>> [ 121.243012] CR0: 80050033 CR2: 00000000 CR3: 02ec3000 CR4: 000006b0
>>> [ 121.243012] Call Trace:
>>> [ 121.243012] kset_find_obj+0x3d/0xc0
>>> [ 121.243012] driver_find+0x16/0x40
>>> [ 121.243012] driver_register+0x49/0x100
>>> [ 121.243012] ? i2c_for_each_dev+0x39/0x50
>>> [ 121.243012] ? __process_new_adapter+0x20/0x20
>>> [ 121.243012] ? cht_wc_driver_init+0x11/0x11
>>> [ 121.243012] i2c_register_driver+0x30/0x80
>>> [ 121.243012] ? intel_lpss_pci_driver_init+0x16/0x16
>>> [ 121.243012] mt6360_pmu_driver_init+0xf/0x11
>>> [ 121.243012] do_one_initcall+0x33/0x1a0
>>> [ 121.243012] ? parse_args+0x1eb/0x3d0
>>> [ 121.243012] ? __might_sleep+0x31/0x90
>>> [ 121.243012] ? kernel_init_freeable+0x10a/0x17f
>>> [ 121.243012] kernel_init_freeable+0x12c/0x17f
>>> [ 121.243012] ? rest_init+0x110/0x110
>>> [ 121.243012] kernel_init+0xb/0x100
>>> [ 121.243012] ? schedule_tail_wrapper+0x9/0xc
>>> [ 121.243012] ret_from_fork+0x19/0x24
>>> [ 121.243012] Modules linked in:
>>> [ 121.243012] CR2: 0000000000000000
>>> [ 121.243012] random: get_random_bytes called from init_oops_id+0x3a/0x40 with crng_init=0
>>> [ 121.243012] ---[ end trace 38a803400f1a2bee ]---
>>> [ 121.243012] EIP: strcmp+0x11/0x30
>>
>> How did this driver ever work for you?
>>
>
> i ask my coworker help me verify.
> i will check the patch myself, sincerely apologies for this.
>
BTW for which SoC this PMIC is used for?
Maybe it would be useful to have some development HW to be able to verify patches.
Regards,
Matthias
next prev parent reply other threads:[~2020-06-09 12:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:38 Gene Chen
2020-06-08 10:01 ` Matthias Brugger
2020-06-08 19:28 ` Lee Jones
2020-06-09 11:43 ` Gene Chen
2020-06-09 12:01 ` Matthias Brugger [this message]
2020-06-09 12:53 ` Lee Jones
2020-06-12 9:55 ` Gene Chen
2020-06-12 11:17 ` Lee Jones
2020-06-15 6:57 ` Gene Chen
2020-06-16 8:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db40ad0-faf4-2a4a-8514-fed59d5053f7@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®