From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566E5303A1A for ; Mon, 26 Jan 2026 09:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769418343; cv=none; b=HkQyYzKtvYIjcvW3iKlui9fp4YGLBFo1uzu+wmodxa0RaPK2ru1jQkKNZlDnnUatRq0nZTtcmNNj73ncSoBI/TzfauDEXYhaL/3dJWlhwaNz+It735vkz5JOzm/1gWlH9c5Q2DL1DNTVtbeOelNcnWTXBhMbCRGixb3FcV3IX6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769418343; c=relaxed/simple; bh=GDq+qoAUvzLsEjMdNageU7aMHOx0h17R0XljH+D+e/0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=LZQV+cJNbSDpmdHonHq9Vrn2nNJ/m6fTtRH5hyIMVbXyS1GOdqcgcDnRbYPjdjQhGZAs68g+hep1lC1IQevaxXHAc4OAmn3XDB035X0ElAsKFvIHsRVDv8ml6npyDycJSoI8lCfl4MVItTapvA5MNITEdSSNOXuPkRoxeMzkQQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=XJ1Kyd/j; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="XJ1Kyd/j" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260126085703euoutp01c07d43b0d7504ea6f550f8dbbc4c317e~OPCLDofK71928519285euoutp01V for ; Mon, 26 Jan 2026 08:57:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260126085703euoutp01c07d43b0d7504ea6f550f8dbbc4c317e~OPCLDofK71928519285euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1769417823; bh=PWcnq9fS5szFbjeETPL6IVSHfuuHn9KkLDU267P2J7s=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=XJ1Kyd/jacBLckjoc9q6J+PjMcGS98Ycr1zUlH0t8Zc1c1FHEOhgAMZB27d0fppp/ 6wIF20UUhOo8cNSkR78SP6ZTumJN7SQiuspM+BOQcu2A9/yPxw39/cYReBwagn3ZxM 314hRMlZUIUHMp/KScTzc7pms+qnMgCzpQ4Qrmx8= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260126085703eucas1p1b2e7523f2f899396b9bc5eed64d63a7b~OPCKptgbw1601316013eucas1p1t; Mon, 26 Jan 2026 08:57:03 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260126085702eusmtip28f556c7e1168f5170037948f35863cd0~OPCJ279El0256102561eusmtip2k; Mon, 26 Jan 2026 08:57:02 +0000 (GMT) Message-ID: <1db5ffdf-924b-49cb-a057-802a1bfe6073@samsung.com> Date: Mon, 26 Jan 2026 09:57:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH 1/3] drm/bridge: samsung-dsim: move bridge init sequence to atomic_enable To: Kaustabh Chakraborty , Inki Dae , Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20260124-exynos-dsim-fixes-v1-1-122d047a23d1@disroot.org> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260126085703eucas1p1b2e7523f2f899396b9bc5eed64d63a7b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260124172136eucas1p1e7a2da65c3fca268ea68f12506c6c19e X-EPHeader: CA X-CMS-RootMailID: 20260124172136eucas1p1e7a2da65c3fca268ea68f12506c6c19e References: <20260124-exynos-dsim-fixes-v1-0-122d047a23d1@disroot.org> <20260124-exynos-dsim-fixes-v1-1-122d047a23d1@disroot.org> On 24.01.2026 18:20, Kaustabh Chakraborty wrote: > Since commit c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain > pre-enable and post-disable"), pre-enable sequence is called before the > CRTC is enabled. > > This causes unintended side-effects (abberation among potentially other > things) in the display when samsung_dsim_init() is called in the > pre-enable part of the sequence. Call it in samsung_dsim_atomic_enable() > instead. > > Cc: stable@vger.kernel.org # v6.17 and later > Signed-off-by: Kaustabh Chakraborty I'm not sure if this will be needed: https://lore.kernel.org/all/20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com/ > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c > index 1d85e706c74b9..975f8b50ae660 100644 > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > @@ -1655,6 +1655,13 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, > } > > dsi->state |= DSIM_STATE_ENABLED; > +} > + > +static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, > + struct drm_atomic_state *state) > +{ > + struct samsung_dsim *dsi = bridge_to_dsi(bridge); > + int ret; > > /* > * For Exynos-DSIM the downstream bridge, or panel are expecting > @@ -1665,12 +1672,6 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, > if (ret) > return; > } > -} > - > -static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, > - struct drm_atomic_state *state) > -{ > - struct samsung_dsim *dsi = bridge_to_dsi(bridge); > > samsung_dsim_set_display_mode(dsi); > samsung_dsim_set_display_enable(dsi, true); > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland