From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754002AbcGUULH (ORCPT ); Thu, 21 Jul 2016 16:11:07 -0400 Received: from mail-bl2nam02on0095.outbound.protection.outlook.com ([104.47.38.95]:13056 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753876AbcGUULF (ORCPT ); Thu, 21 Jul 2016 16:11:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=linda.knippers@hpe.com; Subject: Re: [PATCH v2 2/3] nfit, libnvdimm: allow an ARS scrub to be triggered on demand To: Dan Williams References: <1469065850-32401-1-git-send-email-vishal.l.verma@intel.com> <1469065850-32401-3-git-send-email-vishal.l.verma@intel.com> <57912512.5060202@hpe.com> CC: Vishal Verma , "linux-nvdimm@lists.01.org" , Linux ACPI , Tony Luck , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" From: Linda Knippers Message-ID: <1dba81aa-3ca2-a843-7175-6216be8ee4a3@hpe.com> Date: Thu, 21 Jul 2016 15:55:20 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [50.187.52.22] X-ClientProxiedBy: SN2PR80CA013.lamprd80.prod.outlook.com (10.141.39.151) To TU4PR84MB0238.NAMPRD84.PROD.OUTLOOK.COM (10.162.187.28) X-MS-Office365-Filtering-Correlation-Id: 92717f44-4482-4ee2-df79-08d3b1a0f639 X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0238;2:hXeqENyzC/pshBs9hVjyZ74OomD2LpQ9wd5nAo0DewYv2+6j6rdfnB+3pgwYG+4Ch1BhBWlCm3gk7PEUDfwGOks9fcsX8fS9IhSVbm68eiRZ+W7A/O+xNsAfz2JCoCnI7643cTeVtB/1jNUkWoAztMQpwYm/RZUzdSZsFs+42pyPD8rLDzrbKF7zTP1nB1pe;3:BYASC45PmKuYKmzJMXJQ5MgR/I0ucYT1Hn7wP4TnLFX4Rf2P5guQDPGYUfJtaHgeyqCylgbJF3wee/Lof2DMsgYMwlhNKwqvoT0OBoE9q/tZwKitoPEu9CXkAg4YtGRC X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0238; X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0238;25:p4g3Hjvo6PVTtez3PEt4Fs3QXcv7+PE0Cqd4xaIEeaansSec9MJr67LYVKkwSLHJaMlq4lJdqbT9CDgG5OmwbFg9Iz7E7cF0k/N9sX32dKOOvSjL6CwY8kykxc7fr+DKXa6GDdXdtGKjNkIrcu9EjNQbjztRUF2SP46/HM1lLY0OQhQUYQDb9LOdGW2auwPAX7pUNzVnolerNqwYA2fitwH30njpdRSi4WGcNPCqah/3SSNk1pD+QKGcWhFN1BQj5hyre0iaOWobyseAlxH+f5erOoHNnkH20mZm89V2OEwKrrwB1mKICfE+udcFVaOifErsCgiMqYt9nN0yR2b0RaLhmvO0PCTZO3uUt8iSACFwmUMhCFRSoMSE/BMazVaHaMt6M904x1048tE4iZbMQIPsfOCzOp4IPxpCFhl6niIKg4lLU+NR4eAxY+tYk2FpK/t0WKLDDkZc20lUxUD0IqpBj8IqUFkZlxoPhWI+HHPlHlSRYkr9PmUwA7kQLuHjhm4FqNl8/TZsRXcJ9K7g7hADAvlGnLA0juogr5MTrV9cCKRLiF6Scc3+2y8w/u8XrFEJlBuPlHMfaxoP/o3AadJn1f5PWQDthqnsXiSpI8rRz7RgUAPnQar2n9P9Z6djR3DdOS6XrGdcfdrIMRoQk0pUiCljqAkbvhRbi6lZBqXcti4j4zbXh5dQ8iVdSc1y00R2aFYHKqkrfJX4UA5S0jH4vBwmQZz48gxQe5eHGlM=;31:useUqg8VTbv2Kl4anGleYSHXS9aMXAFBlTqGcPGu6ogfrApQ32TiLlsBay6lYr1RAenrBfSJ7IkXTA2UDeGtv8aZitp9P7o4DhKMcdbZQZNgqYh9GO/bhMZ2P/Zwtlr3aOxRzgyEnWMFx3blpP5Ju9Mwm7OjN8Qtuifw7oLCCvNhedHMuWmxXVULhirgfZ0D+m8Ntb/kDFtHNCbmQYeqXA== X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0238;20:3XVIoFuEbYdtDZ9VpuAKZFYndWvDXMRmZn7B1F9EEPN3BGZLLJA5OCsyENC31YVlIKEZMzGUdRf8vTyR5x3UfDHTzzpUSwAknWcsb1ivYtvopLk1RV1rI5v83lpuoAspxB0+3/9orZkTPT+qSXlVV6h+jYbS93pQ2+BLkhktSK+P4+mtjlnBJzNVATR/z6XRtFyFZVA6EnEidJ/7DTcdo+aOI/NrkyKp92SVBJVMHmNhn/vAfeoRZI0cIVRTB43OfxpFMoi+9DHKjidL3HtgRav6PAgbAKMN/zN5vfhLK7zob1ZyoS31kj/buL7vJhQ97MPeAWEGY/+1Jiov49hcCvYUAcblQ+PfIHLogw1yP4nGVGDixKD4SYU/VjlSZKPDQHuKCGSBQ1YTZoEQhED3e92mhfYvPsCJEM2T1HAbgHXs0SDBzfz7yvRASjezBNCJGksKElCOIbjOVBHYoOnVtRfM4TKHUow+EmIeDJyBZsABNm+SZOBnAbQtQAmSk6H+;4:Z5ruUFyEgjAJrQ2Lq5iH6do0i49PUc0g+XudlqnLgAZrEIVIz52+wihGOmlepzujkDQ81rjW3XWt7GC80/rU+hF+4G48WFg2SgQdeELmbddAPGiyNwslxw17LGb/IgOLGU4eLR0gc8nGe2FyXRxbZI/ZPrYk5qDHTTF8dD1TwqvXDxgBoBa4OkY5d+EaZ0hog+RRC6GfSP5HjHF+zHIrkwP0SyZtUrWEADlQNdRSIaukQE+YDmN78Jan/iTVvQmJSmf4GP6tk6tOmXRHDQ5VHgTpTglSEO1wYBF9stpjXuFxbIY83LzZ0uNswFmX4zngeShvbMgAxMV33Ly1beTowVj3Nb0c1373J0Yitdi5/Y6G0+408cuAduk1pu8LnK+/IVRz5skTiftsXaT+L3uWJbQrCaLLyuRHhSMv1iY84mZIZlisGD44LB6ZLTZTnoBY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(227479698468861); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:TU4PR84MB0238;BCL:0;PCL:0;RULEID:;SRVR:TU4PR84MB0238; X-Forefront-PRVS: 0010D93EFE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(377454003)(199003)(24454002)(305945005)(101416001)(7736002)(106356001)(4326007)(81156014)(81166006)(8676002)(33646002)(50466002)(230700001)(117156001)(65806001)(19580395003)(54356999)(19580405001)(50986999)(66066001)(47776003)(92566002)(83506001)(93886004)(65956001)(7846002)(76176999)(86362001)(31696002)(2906002)(586003)(3846002)(64126003)(23676002)(68736007)(6116002)(189998001)(4001350100001)(110136002)(42186005)(31686004)(97736004)(36756003)(105586002)(2950100001)(77096005)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR84MB0238;H:[192.168.1.7];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtUVTRQUjg0TUIwMjM4OzIzOjRWTEsxeXdxMmJLcVZ6NEdiMjQxMHJldC9x?= =?utf-8?B?a2JEb01aUUYwNGxSUHh4WkVxTWF2VlEzNWRib0xac0M2UkZKZzBvbW1qMnpk?= =?utf-8?B?K29TLzNpSkNPcC9KVXZ0WHJiUjJaVitnbVRJbUlZVjQ2NWR1aEtzdzFyZ0wr?= =?utf-8?B?bkRhYTFGQUxjZnZwc3NjYmV4ZDNxRTRnM3FFdWZaOGFyMHdXcVc1UytIM2VU?= =?utf-8?B?R2ZFZmZrUzVSc2duem50bEJ4UEpHbnZxZnY4WUJrK1BRbUxFMG45ZWtCN0dC?= =?utf-8?B?eklBRm1GZ0ozbW5LZWVxVnU0bDlsZ3RTVy8rY2xjRE10QlFLakJpUWlzMDFm?= =?utf-8?B?dUh6eExOVGVUU05va0gzQW1zbnZBSXU0VEFPUVBTWDhmSUU5ZnZFV0RFMUJt?= =?utf-8?B?RkgrZkFUUjUzMjRWNjFGYWRCRzkwcFFmd1hISEtsbzFZbG00S2pxaVR3NXdm?= =?utf-8?B?ZjBFeTBIZlNZMXFHb29oM3RPSHg2a2Y0ZEJhdlU0NE16eG5oQ0hpVTBHMVBS?= =?utf-8?B?Z3ByYzNmS0VnRm1KbHlMcVJXUTRwV0JsbWRIWHFSQWx0aDBCOGdwWkJoZWZ0?= =?utf-8?B?UFo2YmNEYW5LZVBFeGVvMzNJYlREMEtkTUh5RTBLRTBCWUdBa2RRak94ZHI5?= =?utf-8?B?SEF5dElMbmVWWVN3MCtYRWJ3ZXZNMU16OEh0WDU1OFlkVzRWVUNSR0tLMDRu?= =?utf-8?B?SHdNcGJsVkpJNGNheGJYNXF3LzdLd2ZBUjl3TndSSWE1Q0lSY2NxZUs2ZGs3?= =?utf-8?B?OFVkUEoxRGtKVkxValIrTE1nTzJlQ0I1dzFrT1luWWJVYXUybEFZdlAvaHd6?= =?utf-8?B?YXFydjFjMGtYRmNFcDlxZHdFd0ZWUjRUaXF0cHNrdDJsVUx2Y25xN2FHN3o0?= =?utf-8?B?b3dZSWJmVzJmWENSNmlFN1gwVDVZMHp5bEFTQmZTbEg3elcvMDVsOUlFNGVR?= =?utf-8?B?dnZhYlhKbDJWQ2JuRzh4enQwU2x1d3hRakdSSHhaTldYUkNWTmZKNENRd1p1?= =?utf-8?B?bDlVMk1KSDA4T1BEdGVtbHlhU0dzcmlpOWRzcEtPbWJGaUFuS1UvdmNIbWJJ?= =?utf-8?B?OWtvR1VtVXJ0U1FMMGJrSUlvZFRaMW0xci94TGpBZWlVUTd1U0VFakRGUTZt?= =?utf-8?B?bEo1SkpuSTRXTnVXbjdNTnRjdVhiYmdGVkgxNGlkVlRoNlphQjZRRlFPK0Vh?= =?utf-8?B?NmhiaVBHZE5qTVhvRlFPMUI3bEhxTC9LbEpkNm1RNklwYVBpYUdkWGgwSWVy?= =?utf-8?B?ZlhUa3hnTjJRY0dyZ04xc1ArdDRhRVRGTmQvWlJGMldKRW00NXRnWVZlYXky?= =?utf-8?B?ajFHNW1XM2g3VXRJN01KanhwZS9aVmx6alRPRTVHbzdway9jclFNK29WbWY3?= =?utf-8?B?QmozdWdRelg0M3FuZlh4TG84ZUFJcEluUUUxSjd4UEFsMEd1a0xlazF3QnIz?= =?utf-8?B?SXFmZGcveHp5N3VzTCtNd0ZFNTJ4ZWVHVDZacHBub2F3cG9QaVlCbW92dTUx?= =?utf-8?B?SThSVkVHalFMT0l4ZXg4bit4OHVIbzBQOHpzSkFIRGhta3UxNnZWVkx3RVJl?= =?utf-8?B?SDFlZzY4R3JGTEo0VVBxM3ZtK3VSNHdSYjhiZWRCdE16ZmZvNUYyNlIxZkMw?= =?utf-8?B?SUlNbHg1cnhxQjMwV2VCTE1lNEVCNmYyZVdja0FvTXlFc1I5SVpKaDVKY09B?= =?utf-8?B?WGVsTmlLMGs2TUZKUWdWaWdRblEvZlVoaVdjY3hCcEM1OEtuRkxjVEhsTlhB?= =?utf-8?Q?023BYXg5SgMoKBQpicJHRAxjVfed7GpLQFRzc=3D?= X-Microsoft-Exchange-Diagnostics: 1;TU4PR84MB0238;6:xZmHUJEvSo7qHr/seljNCrvw9v9O3vc/xFpAkXLHnRhFoT1g7VK8X1Dwp1v6mp/ZMBOvvVtHTv8cQqzDns7yoGwOAf75PutxlFBCu22Mx4Fer3VInnFtVqGR/7rCUXW/wIPkiywMnnsFhhMcfEcdwCMDMV8B7J0b16OiC5g3k/euldtJ2d3RG1QIcxbGO6Enrxh8pYeLUbvMhj/1+i7zYBwXSLylfgYbr60Typ16aOP7kJHZphiCBxT+oM8GmaVbOSbw8/rK+QgFE5oSh3okWoPdq17urtn3rYTR5s0l+qELlINW5PUWjM12j0uWI3LbCF0ryYImEtrdvvgs8bu3mA==;5:m73c43pwvxAgRoY8OujqbAnThvyXSlz/Gn1KB/n8V9BO6EgEyole/OVNKbyAToNL2f/k7SEacCdGltvi5hfLRu0HjzcnjXkBekqVqJYwEO/8h19SYzNzEecD2Gw5mE+rXg9QWToMtkEms3YNZyA6zA==;24:KCp+HZTE9P9w4m4eJcX2WcaPRYg0t8ljVG/6xFEJQ/PIHkFzkFhOgJ6MG5HilJwyC/pVHGHYQcvIWck7nsne9HZknAryJCRE9VdAxA4PN3Y=;7:WhhEyBr0ZQylJExjK1ss4nWYAVVMMWFQZi/LOMUzirSvwfTFFxCl68CVMIQl+gfue/0MM3g42dSNkh3KpjzFlkl/BjOnmznjORvcbRbMQW7R0Txpyze78RjWTiP525Zu0Hm32IIn18W7H0jzhV3DGcqsYTsldl3aCCxvq7oscoiBr8+KMXSPc3XRsNjKAEEa77ehOkhy7yA1yiyjM4AIWLZvSl+1I6n9vJpS8Pz9qEwTJV9g/INC3UNNVPNcX4uN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2016 19:55:26.4535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR84MB0238 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/2016 3:46 PM, Dan Williams wrote: > On Thu, Jul 21, 2016 at 12:40 PM, Linda Knippers wrote: >> On 07/20/2016 09:50 PM, Vishal Verma wrote: >>> Normally, an ARS (Address Range Scrub) only happens at >>> boot/initialization time. There can however arise situations where a >>> bus-wide rescan is needed - notably, in the case of discovering a latent >>> media error, we should do a full rescan to figure out what other sectors >>> are bad, and thus potentially avoid triggering an mce on them in the >>> future. Also provide a sysfs trigger to start a bus-wide scrub. >> >> I don't see anything in here that checks to see if the platform actually >> supports ARS before setting all this stuff up. Setting up an MCE handler >> and exposing a sysfs trigger for something that is optional and perhaps >> not implemented doesn't seem helpful. Or is there a check that I missed? > > We'll get -ENOTTY to ars_start(), but you're right it's a good idea to > hide the scrub attribute if a platform does not have ars support. > > Vishal, can you add an is_visible() routine to > acpi_nfit_attribute_group() to hide 'scrub' on platforms that do not > implement the ARS commands? It's also possible that a platform might only support ARS at boot time so subsequent scrubs would fail or not return any new information. I don't think there's a way to know that in advice though. -- ljk