mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform
Date: Mon, 27 Jul 2026 16:39:31 +0200	[thread overview]
Message-ID: <1dbdd44d-070b-4abc-a79f-3cde09de7d74@oss.qualcomm.com> (raw)
In-Reply-To: <20260723-usb-shikra-dt-v4-v5-2-5b69d9eb0888@oss.qualcomm.com>

On 7/23/26 12:33 PM, Krishna Kurapati wrote:
> On Shikra CQS platform, usb-role-switch is handled by PM4125 on primary
> Type-C port and Cypress PD controller CYPD6129 on second Type-C port.
> 
> Since those changes are not yet present, enabling both USB controllers
> in device mode.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 35 +++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> index b3f19a64d7ae..006e24a62f5c 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> @@ -38,3 +38,38 @@ &sdhc_1 {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {
> +	dr_mode = "peripheral";
> +
> +	status = "okay";
> +};

$ rg shikra-evk.dtsi arch
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
9:#include "shikra-evk.dtsi"

arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
9:#include "shikra-evk.dtsi"

arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
9:#include "shikra-evk.dtsi"

I think I asked either in private or in public, don't remember at this
point, just enable these controller once. They are all the same board
with the chip and PMICs swapped. Override just the supplies in the final
DTS files.

Konrad

  reply	other threads:[~2026-07-27 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 10:33 [PATCH v5 0/4] Add DT Support for USB on Shikra Krishna Kurapati
2026-07-23 10:33 ` [PATCH v5 1/4] arm64: dts: qcom: Add support for usb nodes " Krishna Kurapati
2026-07-27 14:37   ` Konrad Dybcio
2026-07-23 10:33 ` [PATCH v5 2/4] arm64: dts: qcom: Enable USB controllers on Shikra CQS platform Krishna Kurapati
2026-07-27 14:39   ` Konrad Dybcio [this message]
2026-07-29  5:13     ` Krishna Kurapati
2026-07-29  9:23       ` Konrad Dybcio
2026-07-23 10:33 ` [PATCH v5 3/4] arm64: dts: qcom: Enable USB controllers on Shikra CQM platform Krishna Kurapati
2026-07-23 10:33 ` [PATCH v5 4/4] arm64: dts: qcom: Enable USB controllers on Shikra IQS platform Krishna Kurapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dbdd44d-070b-4abc-a79f-3cde09de7d74@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®