From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: marijn.suijten@somainline.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH] regulator: dt-bindings: qcom-labibb: Allow regulator-common properties
Date: Wed, 18 Jan 2023 13:26:04 +0100 [thread overview]
Message-ID: <1dbfb913-95c3-c9c6-1797-e4d8387552ac@linaro.org> (raw)
In-Reply-To: <ee9ef65b-38c6-2283-b1e7-abf49abdccd6@linaro.org>
On 17.01.2023 09:51, Krzysztof Kozlowski wrote:
> On 16/01/2023 10:25, Konrad Dybcio wrote:
>> Allow regulator-common properties on lab/ibb regulators, such as
>> regulator-always-on, etc.
>
> Are these proper regulators? If so this looks sensible. Why calling it
> RFC? What is here questionable?
I really had no idea if this was the proper way to do it, but
dt_bindings_check and CHECK_DTBS+example dt were happy..
>
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> .../bindings/regulator/qcom-labibb-regulator.yaml | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> index f97b8083678f..c0be7d5a6d40 100644
>> --- a/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/qcom-labibb-regulator.yaml
>> @@ -20,7 +20,8 @@ properties:
>>
>> lab:
>> type: object
>> - additionalProperties: false
>> + $ref: "regulator.yaml#"
>
> Drop quotes.
>
>> + unevaluatedProperties: false
>>
>> properties:
>> qcom,soft-start-us:
>> @@ -46,7 +47,8 @@ properties:
>>
>> ibb:
>> type: object
>> - additionalProperties: false
>> + $ref: "regulator.yaml#"
>
> Drop quotes.
Ack x2
Konrad
>
>> + unevaluatedProperties: false
>>
>> properties:
>> qcom,discharge-resistor-kohms:
>
> Best regards,
> Krzysztof
>
prev parent reply other threads:[~2023-01-18 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 9:25 Konrad Dybcio
2023-01-17 8:51 ` Krzysztof Kozlowski
2023-01-18 12:26 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dbfb913-95c3-c9c6-1797-e4d8387552ac@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®