From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233EF39A058 for ; Wed, 13 May 2026 21:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778706653; cv=none; b=jpfJLT745wjRwPTI0lsblTJ3bCZhb1ynlP+b0jM+SEwqeuh2EZ/ulgoFGbcJ6rEcdk4OzKaiBRaCoUfevu2JVCqr28NYKU6/VvMgu797l2/SISWwMHrpcnT3KNAMJ+Tya8Ak1z7XkivV1wtVMWXumoFAdXMQZbI/t4c6AWeZ4z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778706653; c=relaxed/simple; bh=nuZfkdDWsvYa1cNyD9mSrJeJvpMLYKmpe1Y7IstjXJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VApDgsgLc0Kb95ABfFQCSow4H7a0xpIjzcj2RB4EyRfhvApi39Mh+RTNLM7wPEps/gbQEJwN4me8Ao9Rcc/29v0mDU8RhnW2gFf8j+JxL9AzLj/g4I82VYRESOtwf5tk4M5F3i4mWJEUTc7CTWoZeSnQcC6d5RkL9896uO58Hqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V3ZTMjoa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K4Dqgf6k; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V3ZTMjoa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K4Dqgf6k" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DGAqMW2524309 for ; Wed, 13 May 2026 21:10:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EP3xjrgY2XMSo+tnYkujYFohkhHAzdynEqCAcazAHkk=; b=V3ZTMjoaZ1BdtS+p M4LwfZsI/ayfy4CicDWmR9bbK1xGJksY4o9heQnzoxxRlRjF/DPCWgtb7tdCZmHj wSAaVMLrFYmgKqc92ECa6P2gyokl7KtPbKSNHLWV1LBQf8UipU2KH9Qh8EvzTk2K IXxRnMrNhNAjQkE3cBYvWA8BMRy8S0PVNrTA+3Hap0V1tqq8IIJ1POwdw1ZpRVGe aAiulVO6ru3Lo0zgcJgBk2blQ52jb06umsRDB9rFq7cdqI6BrgHlmUiiNz2B795O GXBErlTmAeL8cS25ZkILYVSQ9YQ3BbQ+Bb8Y2yByzvioM3zS2beL9a2oLzKXTL2S XS7HLA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4vkjh6db-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 21:10:48 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-354c44bf176so8595343a91.0 for ; Wed, 13 May 2026 14:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778706647; x=1779311447; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EP3xjrgY2XMSo+tnYkujYFohkhHAzdynEqCAcazAHkk=; b=K4Dqgf6kgkKY426jY/k0pSK6XvWATK3gWQCGVDJCLeGdWnNbdLDpeosKHawdNZOFKY DPA0PhDcrmKU01IfXGyJF4SvH1tRSRwCLsV8H1TrEInkUrVKJ87cmDMsT9WKlG/zoobo KP4s0BuaElcp1a9nhHeX+Si3aWUUthzItUfAg/wdX1t3OJ/r1aHRBE7e6i3cNLLCGqev WHYxB6vIl0u3ikWsgzVDLhS/gMt8wqlaOxsFFH1ym7uJ9rGfnSW5BGSQDimVuJw6twgM ow8Mr14XTxdMG7ZvxF6/JpHOl2G3InokqDX+mblO0BGRaVM1xQzqn8LaDpcJ4mG9naYY JEgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778706647; x=1779311447; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EP3xjrgY2XMSo+tnYkujYFohkhHAzdynEqCAcazAHkk=; b=lhCppF0VSfG1iIHAdc06wGrOch2UTy0x+f0j6VakSl2CiscJyTLnS32Z9iQr7L+gFW hziON6Q35SJpL4jDLDa42ck/vUbPJK610nsWeJZH/8bVfrMnO29BgQChJ8FfkLFPGLxb mtuuvmwrSqRw1X1O4j6qtkIns2g7kxhCm9UUQC8VsBDcEeo4E47mJEKH9YnZ9eHWNiFm LlWjElQT2ponbpxIOZecj9HsAqAslB03+PQzqE1LInhOmEm1dl9RYSs+ORuxmDeA3NQG FT0GobWQ9+dsBoFbxOrUd1c0P4TeCUPNSoPDBdYrgaYYvNgZJ2MEV9eHBJ1PhS7oFW4o Yq1g== X-Forwarded-Encrypted: i=1; AFNElJ8cWFJ6J8aDP8z2hbpWoAJ6h+6ZQNZHnaEzG/7hfd+dT5FqDEcvWZuDOHn3EKqHIRTUZuuqRoajE1TVDSU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt82lZCTRwLEtxhdpQbM9O8oFkVit/ygCOP3VDmtqg5LBoRMys H4+h9LPT//iCS1wA4oqiaPJ9brf+N8X4KyndwqiaSIb4BenscWXSK5cFxMFzSmFCc67oyEi+mvF MnGDGKQY75W5pyYfuaC337MtsqkOFXisLUDVe/la+8pVnyWDWu3IH/m2Ra5h7978I7VQ= X-Gm-Gg: Acq92OFwx/Y7dk/fGOxrQl0NDshYz/pnQx753Krtru2jsbdJ8jJ8jSemiBnHym5u5Tn LvmWrX8bim/NCsHHyOKRwRTZ1JEOYX+bQRS4bNpsjuIlZ8k9oKAzgOr8q/7CXv82U5HRVxllMMy gX9wBfDM0OFmqMnT18rI49lHX6WAiQyyz0HdESBzrJQu3Tf7k3aW7LSGsACH1zDsjpaqqXEqtGn QdPo+qAnR0negXsS6m9JLhMDtsZAhNH2kV1K92yIsAUfAW6GaXBJ/2cKyTuYXRZRijKMTqy7iKp r80NTLb0RhugB7+m92a2TiKOttTNUh53IQYEkO/Mb+dT6i14Qj0DTuWAnw8ifVs4fOlnjdMTq/7 bw1iOmpF/V3vZyUzG+vDoXuzpQDJNcXq4Y/tEbSJv/Gqo X-Received: by 2002:a17:90b:3a46:b0:368:ac5f:d313 with SMTP id 98e67ed59e1d1-368f3e7b6e1mr5521384a91.20.1778706647270; Wed, 13 May 2026 14:10:47 -0700 (PDT) X-Received: by 2002:a17:90b:3a46:b0:368:ac5f:d313 with SMTP id 98e67ed59e1d1-368f3e7b6e1mr5521348a91.20.1778706646758; Wed, 13 May 2026 14:10:46 -0700 (PDT) Received: from [192.168.1.6] ([106.222.229.33]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3692f4a3c8fsm187754a91.16.2026.05.13.14.10.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 14:10:46 -0700 (PDT) Message-ID: <1dc269c5-fe74-427b-94d6-85b5aada318d@oss.qualcomm.com> Date: Thu, 14 May 2026 02:40:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 2/5] drm/msm: Centralize the standalone drm device check for GPU To: Dmitry Baryshkov Cc: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Neil Armstrong , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260513-gmu-sync-state-fix-v1-0-6e33e6aa9b4f@oss.qualcomm.com> <20260513-gmu-sync-state-fix-v1-2-6e33e6aa9b4f@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: wpmuIyNFfnblTRcfXhrB_eRUstMGXieM X-Proofpoint-ORIG-GUID: wpmuIyNFfnblTRcfXhrB_eRUstMGXieM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDIxMCBTYWx0ZWRfX9MjEpjjqAGv/ QxJk4Od5yum7QfVUJ2Wh7fYWaoj226pgoGSNPEutoqDqPegD/cUfHe7ZbYIYAJfkgkFkFbl0+o6 m2AP3Nz6Bk9AZ7i6qegXfvFW1O7dOL4EeMCoh7JNI3FKhC9jfGPTFWhHcYafNljS1siW1v1rwhS iEC+jsinD7DAtZo3rRl6dYBNUjB1ZkjmxNNfm/8vPiWmZFoxNJjzFhurNbKzIlQsOWykrAqKwWs K2mefbcg0ef7dpVQ3J0WsPqhcB0OSCti2OuSCYPuPV3IWexx43f+E/RteS16/ZfwqRrBb0ZWVwg Ymly7q601dA5KQget+3L0HYVwQX/m4Mm9x6ZQ/bVxSWuUh9D9lt7WLs2GkOsbAAEAONVMlfHo90 s7p3t7+uMlADBl0K2clti4vmwFKT+xZyjXsnTWezY85eBWccNF/ur2CIVY+o9P2EU8W63BFScFj oA70YNuqqNrHg1ZLwkg== X-Authority-Analysis: v=2.4 cv=PbDPQChd c=1 sm=1 tr=0 ts=6a04e8d8 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nm1BsBjGsf7C+PoY3QnOXg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=ZzDrR4TfVffB5w7mJ1MA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130210 On 5/13/2026 11:11 AM, Dmitry Baryshkov wrote: > On Wed, May 13, 2026 at 02:22:57AM +0530, Akhil P Oommen wrote: >> Replace msm_gpu_no_components() with msm_gpu_use_separate_drm_dev() and >> move the platform-specific check for "amd,imageon" into the helper so the >> policy is centralized and reused by both the core driver and adreno probe >> path. No functional change intended. >> >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/adreno_device.c | 3 +-- >> drivers/gpu/drm/msm/msm_drv.c | 11 +++++++---- >> drivers/gpu/drm/msm/msm_drv.h | 2 +- >> 3 files changed, 9 insertions(+), 7 deletions(-) > > For the next iteration please swap this and the next patches (yes, > introducing some code duplication). It's generally not recommended to > have fixes which depend on a non-fix patches. Ack. -Akhil. > >