From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1075F17D346 for ; Tue, 26 Aug 2025 16:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756224165; cv=none; b=qTcr4m2hW5HRf1VOvs+qvy2Di2hcd3cyBG8EIFhkgi4Yhz06KyqH8I/e4/dWgbwdV263yac/2lwTDkl+0LaV/y4JMeTZEKFiwh/y+hjsl1nqg987z2BfsPNbHBPVb0Rs9TCQ6Yn7Smn3lE+PNYm2Axs2a4qSU0fXvaT4XtYa6ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756224165; c=relaxed/simple; bh=3UQpnIJPKnKLpAGt26ffAbECgihu3iAliObcW5TWBeU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bfpiNnkjlS76BiAhLJK/vaXrxpGQnn9+LOyZpI/eXKoKc6zCgaDXftwufQ1zoOjwNF4lZGMQIa17DTWm0nrmLhUf3OmqY0hA/zv7PyHocnCNIqI8+s9XsP2Y7o/uOdlR+ipphysJ5QmuBzbDjiNJ9OiqAlbvVhDX2l1fzlzJFRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LpLPbOUx; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LpLPbOUx" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-30cce8ec298so4434489fac.1 for ; Tue, 26 Aug 2025 09:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1756224162; x=1756828962; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6hKICjV+6/lxNLEk1c9nfVe+ZCE9ECioreCtxFio2KU=; b=LpLPbOUxmF7GImYlxTvLsuZMqiZzQBoaMv+rWsIto8V9hiQoWJowZZxoaqGGbuyoB0 CrRDiM3WLugpla/B2rtUWSaOVmJ3oPVO1LMXE0BB3WvbY20nam7TOV4pCY3Trw81y66C lf7RyWf0zkthHoUCa1ZqiLEu3TUDpT8vwYzF+TmuEAHQ3mTFpcoxa92jX3o1Vdo/derL oEkhakGv1Taci5vrLeq7iqh19nTj/pGrJkNt9JOIxvjXRNaqM3xUwceAVR+CgurpioE2 nbxsoda/y8Qy6NbAjEsrp1GoZYYJjDvkT90axxjjBJjv/zdbbulPV9PG/V13xpF4fTRv Nz3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756224162; x=1756828962; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6hKICjV+6/lxNLEk1c9nfVe+ZCE9ECioreCtxFio2KU=; b=VK2YyHzy7Cq4VajKs+ZES8mSDDlv5Dq5B6I+vKxb6Kz5dOLVUoEWScUQwaBfeuo6gp 6OHWczEE8dSBqbQbKnrmfeFoK9ZgrAxViH9MQG7PP4r79kjMACfnPit30oC+8GpLT0ha p/8FW7HZklnmJ6vDRMrTU1BZvdRJwr3ZEptYWndDRvEPxEcmGJztbCDPhkqmhsWYpmWR GweF2hDOcq0dfglRrEvon/cdaoX2Aw4CXWk7alhbHLbBgttJsNxmCOyfzqM0Tiy98oR+ Q3EUF0Fezj+VdPxIMiCtGTaW1H8TljSzCfQlJ1Uppa2GMmS4sWEBE/gjgK7q/w13l3By KLaQ== X-Forwarded-Encrypted: i=1; AJvYcCX4xnCBIUK/zEEYjeF3he9selHvNUwKAiLGP5n8mxY/qTn3VTpNqdVsFJ2tgtemwOsSjEbflbOArxuhhHo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/IU9S72EHpKAMspF23bTfYKwGYCuGPPII1ydqK/lf25rlrEo2 jPzNJze2uXUrGi4EF6eNaHD8M24hzwoGkhNAhpFxdhq/sL56zrFTKGC50rnWEC0M5Xw= X-Gm-Gg: ASbGncvXeokEx0NLU15YwewM+6303Bk127X0KjLOaiypQMlhVuFrKVjkamDLx1cFVOg tk/YxbDxD81G3pbFbkDXz2B9qj+N3wF1kem0K66T2YoaELXMOu+yuD4ee9QTJOyLHzn52it/V7m 9dJtJG9bdSp+J4OUpGmT3MkETCDaFgZ4oe7sJSrRhTaJz2Nr2YOhiuK2lw212WttNOUUvdsTGxC bECrP3pA91vAKn7nmzD8h0BtektRw8aHMIVhH5F1Hw6LJObLwzGKl1jg4kthfGdF/ImUJxdfUYD Am6GnWNgc2YZFdUyPPWFdDGB+z+8/IahJJBEGarJ92Zq1kUWcZd2tdJBh5fOktt6HeZsZkbihgr Kz7ITwYV07q27Hdf016aijLoXyEd/K7fdxzq0UAwMqi5E41qG3r6hikPSPr+eiYcxgO+SMwtRCU k= X-Google-Smtp-Source: AGHT+IH30+gvcYtT1WdKMDYQghSW8SLUW2fPPTOAELgVrWD2i+MlWze4f6hNHUyN3ijUu3eoWuMyWA== X-Received: by 2002:a05:6870:ec92:b0:301:eb97:1f7f with SMTP id 586e51a60fabf-314dcc14230mr8054282fac.3.1756224161690; Tue, 26 Aug 2025 09:02:41 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:aa9f:f4cd:76b1:fecb? ([2600:8803:e7e4:1d00:aa9f:f4cd:76b1:fecb]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7450e29b211sm2433761a34.21.2025.08.26.09.02.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Aug 2025 09:02:40 -0700 (PDT) Message-ID: <1dcaf589-2ff2-4af1-9177-ee129b403272@baylibre.com> Date: Tue, 26 Aug 2025 11:02:39 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] iio: adc: ad7124: add clock output support To: Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250825-iio-adc-ad7124-proper-clock-support-v2-0-4dcff9db6b35@baylibre.com> <20250825-iio-adc-ad7124-proper-clock-support-v2-4-4dcff9db6b35@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: <20250825-iio-adc-ad7124-proper-clock-support-v2-4-4dcff9db6b35@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/25/25 5:55 PM, David Lechner wrote: > Add support for the AD7124's internal clock output. If the #clock-cells > property is present, turn on the internal clock output during probe. > ... > @@ -1164,6 +1168,33 @@ static int ad7124_setup(struct ad7124_state *st) > } > > clk_sel = AD7124_ADC_CONTROL_CLK_SEL_INT; > + } else if (!device_property_present(dev, "clocks") && > + device_property_present(dev, "clock-names")) { Found a mistake here. This should be #clock-cells rather than clock-names.