From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341AbcL3U4m (ORCPT ); Fri, 30 Dec 2016 15:56:42 -0500 Received: from mout.web.de ([212.227.17.11]:63278 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbcL3U4k (ORCPT ); Fri, 30 Dec 2016 15:56:40 -0500 To: devel@driverdev.osuosl.org, Baoyou Xie , Bhumika Goyal , Binoy Jayan , "David S. Miller" , Greg Kroah-Hartman , Larry Finger , Nicholas Sim , Salah Triki Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] staging: r8192U_core: Use kmalloc_array() in rtl8192_usb_initendpoints() Message-ID: <1dda87f1-8c49-ef2a-fa1c-0ebec5bca92c@users.sourceforge.net> Date: Fri, 30 Dec 2016 21:56:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:QEHXJO7bdoX1nlY3EULMJQBWLvNOeY3jtkS6ZYEGzrWT+Mx9SCi VYCwYic/7K+K/BEHP7yi0yUC9+nckzfEs8x1+7fnh1Egdq8zKAdUa4ZNrn2r5pb3sZIh5Q2 EdMmypPPQf3o9r/8fUs62ybujrim8WMJ8Bslbb7DKpW2VL6nVLHcWnaF5AHXSz9Rab2Iyn8 pyIuNww1/yZfGAELA/U0g== X-UI-Out-Filterresults: notjunk:1;V01:K0:T5Dm8LvfO/g=:p0lDm6qk8KZTDMlKy7+VD2 8AqWpp5Wo+gQNApx83QguWDN20TWt9Ioyto7afkfeO1N/mJlsJiyH6+VH82Qx4CgQYMZyn6n/ Uy9rpex8HDN1kfVU8WQzjk4VekutHHz8WYPX8xZQprQVtWshPxyaaMdI5UFR2SfhSjoOZiBCT 7lGFv4E2y5aEaZh88zYZ52trquyOr9gxwhOgSRB4LW9p4D/9Fxkt8F22+I9dZDZ049RWxI1LW Ls2AmImPxRgtLEUa5jMmM4HPssaDziKVIOHyMFhwRApYE2S5uHfyyNak+FRwSZotgqsOZVJca 2dNWRZDoynboywwJgHqk/DOXHGt+jTysHG9mLiLyljJ+sJLKt6ITtI916b0SfyAAAXRyKKBwV h5lD50JtfethG8xrrzERI6/vwjvMTCvobz1ATPZ2wat0i5tpssmfubcr8jVt5ehTiDmOYvvry SlUwMC/1W+ScZ8OK+WVj76o3lnRUzB7OfX7iu3sMN9eFWoNIK/ILFFnh8jR+aaFgrvNq2xTSJ OS5wlDGGlU3c6ZH9jURahAyqojvTjtkNquevxKWw3qtgOF4GFBfHIf83rt/xkK1Hydap3TEoC eUoStaFXsfeTmdGNK0CLVTg+7bPT5vHpLFamijerjvH8JUmHlsCpObGgL4Fnc6wn+7DZeYdXP gHrGUep9XhESby/2f1STozZEayxMAZSbuqgtJ2ZXpIEUn2RsssfLxE+B8GDtY7x12RGDVQFKk r3ngMdgtCDyWxJNj69/d5KGUYHm7nApl0SHq367okGgPSNAn/mVHzr8cdThGqxa4k0EQrXlzL sn2bQe5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 30 Dec 2016 21:43:22 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/staging/rtl8192u/r8192U_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index fdb03dccb449..e0791d357259 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -1682,8 +1682,9 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) { struct r8192_priv *priv = ieee80211_priv(dev); - priv->rx_urb = kmalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), - GFP_KERNEL); + priv->rx_urb = kmalloc_array(MAX_RX_URB + 1, + sizeof(*priv->rx_urb), + GFP_KERNEL); if (!priv->rx_urb) return -ENOMEM; -- 2.11.0