From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2AD814D719 for ; Mon, 30 Mar 2026 07:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857113; cv=none; b=jHAlYFtJc7OqRWoGS97I8aps1PihKTL+GbshrBvk41NfjpmIHAo4mGqdv3oFkCiM3CQrYYSaEd1kT7SPxifuXWsTb11TtjnbEyVcZhMXPg4nrCh6+5XWYcnRmpYhv+wL2F9iphtUt+XtbyCcNN0MlyE+Rj0bHYdrT3OY7rmTjLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774857113; c=relaxed/simple; bh=oL9QMZXWzFWavGZg81Mt/2mE0KdGaT0F69AV6Xh9OlE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=g3otIAbDlw3VyqhKB8oxvxV/xpI7NEqHJp09Vr1x6kGB/II+FLyqpk4k6TMJVcm5RJvFSN53SJbfzQ1AyEEXu/q1K08/Gu21uWO0djrXfHX9AeD1meKOw8rLitNxMFBxu0mq2O1dFXZ/3JhMFVVKaSDcsoETNiw7mue2pRl4X8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=ALjpHACi; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="ALjpHACi" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260330075150euoutp01a41bfee327071da9dacf488b5a9a2a5e~hjyNeZZvR0045800458euoutp017 for ; Mon, 30 Mar 2026 07:51:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260330075150euoutp01a41bfee327071da9dacf488b5a9a2a5e~hjyNeZZvR0045800458euoutp017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1774857110; bh=UQECHjZYDeo+w0oCxyQjWJgtMtpqK8B8IJ/66Ffxmsw=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=ALjpHACiV7sTvBQIdeYUxGEXlKt+hA0rN0o7wK20EJSsD+2iFob03KZGKB7/3rEHB 2SgtRRtMB+ewKbRXE4iBta05E+/eKKk3rnURg6OiDW5U87YLNo4qljqgXIJwrwfys3 GvgNoKPKsZLVDM9hYbBYWywQDSUWI5Ysv0NV7dGU= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260330075149eucas1p24e986266fcbfc884498f3d8564c82df7~hjyM-3__V2163321633eucas1p2c; Mon, 30 Mar 2026 07:51:49 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260330075148eusmtip2b83cad2e8b7d79f67c0dd97f94f0cfab~hjyMOQal-0750207502eusmtip2s; Mon, 30 Mar 2026 07:51:48 +0000 (GMT) Message-ID: <1de09a99-bf8b-41c2-9dfa-c280877b99ff@samsung.com> Date: Mon, 30 Mar 2026 09:51:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH] drm/exynos/dma: Drop iommu_dma_init_domain() stub To: Chen-Yu Tsai , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20260326093039.1152770-1-wenst@chromium.org> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260330075149eucas1p24e986266fcbfc884498f3d8564c82df7 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260326093817eucas1p24174d4b0d25c7966172c08e305fa8882 X-EPHeader: CA X-CMS-RootMailID: 20260326093817eucas1p24174d4b0d25c7966172c08e305fa8882 References: <20260326093039.1152770-1-wenst@chromium.org> On 26.03.2026 10:30, Chen-Yu Tsai wrote: > Commit 1feda5eb77fc ("drm/exynos: Use selected dma_dev default iommu > domain instead of a fake one") removed the code around creating a > custom IOMMU domain, but forgot to remove the stub. > > Remove the iommu_dma_init_domain() stub as the function is no longer > referenced, and was also made private to the IOMMU DMA code. > > Signed-off-by: Chen-Yu Tsai Acked-by: Marek Szyprowski > --- > drivers/gpu/drm/exynos/exynos_drm_dma.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dma.c b/drivers/gpu/drm/exynos/exynos_drm_dma.c > index 6a6761935224..ccc6b852ee7d 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dma.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dma.c > @@ -23,10 +23,6 @@ > #define to_dma_iommu_mapping(dev) NULL > #endif > > -#if !defined(CONFIG_IOMMU_DMA) > -#define iommu_dma_init_domain(...) ({ -EINVAL; }) > -#endif > - > #define EXYNOS_DEV_ADDR_START 0x20000000 > #define EXYNOS_DEV_ADDR_SIZE 0x40000000 > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland