From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAF9C433EF for ; Fri, 22 Jul 2022 17:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236263AbiGVR6a (ORCPT ); Fri, 22 Jul 2022 13:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232888AbiGVR63 (ORCPT ); Fri, 22 Jul 2022 13:58:29 -0400 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D757B61105; Fri, 22 Jul 2022 10:58:27 -0700 (PDT) Received: by mail-pf1-f181.google.com with SMTP id c3so5040057pfb.13; Fri, 22 Jul 2022 10:58:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XI6aI/fJE0zfHg81LO7kfFCj4mcwWmAT78t/HxVPB5c=; b=qcm8G3X12FJ7VxU+7fJHzlsss77YGiCq30PqsllDJ3BwZglyW2E/4QtoWNt5VxYcwz AsmG6aCV7Q3brPf1PdDmdePBk9P/7CQxlk/6b0uFvle3XnSPYQmOasGfIFZDIIGkoqFY KOuQO1sN9THff/MD6L9Vi9OHUk6NTssqYJB8kYpD8lU747gI/eqvTBnW1cbbXJl22R6q 3+bAeBtUeltArTwekjuTezvAdVoqkOXFJTrxF6gpyO7wnRCN8UijYgk1fQ71FPC5wM9c R2ejg5rspP4AVKTCYmWE8WUjrD0xVQP9TH0m4Pu/Wtb9k9CpPXsry3R6qzyCbCVJVfhv LHyg== X-Gm-Message-State: AJIora+ebT3cI30yjSVoB7f8CIbBPtaWYaqiFQSHXCoMiKEB/G5hMd7O L0slcirHlD/sfAoqhOpJNoU= X-Google-Smtp-Source: AGRyM1tEbmCsZ17e5zfJFAHUCqG+l7LdCnTCt0iQrz00mXvdvvA31CYlcGjTBybG0R7PgETIt6p5Yw== X-Received: by 2002:a63:500d:0:b0:415:e89e:42b7 with SMTP id e13-20020a63500d000000b00415e89e42b7mr821297pgb.140.1658512707195; Fri, 22 Jul 2022 10:58:27 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:9cf6:7e29:d977:6fc7? ([2620:15c:211:201:9cf6:7e29:d977:6fc7]) by smtp.gmail.com with ESMTPSA id y22-20020a170902b49600b0016c5306917fsm4037363plr.53.2022.07.22.10.58.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 10:58:26 -0700 (PDT) Message-ID: <1de1372e-1c69-611b-0999-c162da8013ac@acm.org> Date: Fri, 22 Jul 2022 10:58:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support Content-Language: en-US To: Avri Altman , Can Guo , "stanley.chu@mediatek.com" , "adrian.hunter@intel.com" , "alim.akhtar@samsung.com" , "beanhuo@micron.com" , "quic_asutoshd@quicinc.com" , "quic_nguyenb@quicinc.com" , "quic_ziqichen@quicinc.com" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Daejun Park , Jinyoung Choi , Kiwoong Kim , open list References: <1658214120-22772-1-git-send-email-quic_cang@quicinc.com> <1658214120-22772-2-git-send-email-quic_cang@quicinc.com> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/22/22 00:31, Avri Altman wrote: >> +#define UFSHCD_MCQ_IO_QUEUE_OFFSET 1 > Maybe add a comment above: "queue 0 is reserved for query commands" or something > That is if the query commands don't use the legacy doorbell Is it essential to reserve a queue for device management commands? Wouldn't it be better to have one additional queue for submitting I/O commands rather than reserving a queue for device management commands? Thanks, Bart.