From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1337FC4363A for ; Thu, 22 Oct 2020 10:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E37422267 for ; Thu, 22 Oct 2020 10:35:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="dZ2Bu4bi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896576AbgJVKft (ORCPT ); Thu, 22 Oct 2020 06:35:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:37260 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896454AbgJVKft (ORCPT ); Thu, 22 Oct 2020 06:35:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603362947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7bj/gkiOtWxRriaas+Eg9fuSwfNM6Cn6VTUSXRtCPkU=; b=dZ2Bu4biyrSPNNa7TM1ZJ0TcOD4E9BZzt8z0SvvC2XdLwKtL1Q9Nj/ysADaaUau6dX8zlB zfXGYESxigbwEczzRNm+fnJVYsNBXnQzuaGwUT9jDDTW4dxdaLbY7bJhtczMRUpPV+GZqU r/mqRlp38QBpwr/sgWd4PIggZxgleb4= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6BDE9ACF6; Thu, 22 Oct 2020 10:35:47 +0000 (UTC) Subject: Re: [PATCH v2 3/5] xen/events: only register debug interrupt for 2-level events To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20201022094907.28560-1-jgross@suse.com> <20201022094907.28560-4-jgross@suse.com> From: Jan Beulich Message-ID: <1de24e42-6cb7-4ecb-0eb2-c4a15dc8afc9@suse.com> Date: Thu, 22 Oct 2020 12:35:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201022094907.28560-4-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.10.2020 11:49, Juergen Gross wrote: > @@ -2080,10 +2080,12 @@ void __init xen_init_IRQ(void) > int ret = -EINVAL; > evtchn_port_t evtchn; > > - if (fifo_events) > + if (xen_fifo_events) > ret = xen_evtchn_fifo_init(); > - if (ret < 0) > + if (ret < 0) { > xen_evtchn_2l_init(); > + xen_fifo_events = false; > + } Another note: While it may not matter right here, maybe better first set the variable and the call the function? Jan