From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B62B33B6F6 for ; Wed, 3 Jun 2026 13:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780494799; cv=none; b=t3XRmWuq6nRO4qsrwJdlKukP7saLUdI4q5B+eSUJ9WFnLiSGwcw3u2JSKK1z72VR2AJ7iRYO/LaELfVbo6z9PwQpu4kAgsiQiF37Ge3HTRFtQCzBDhX9dgudgGBII23FePdv/YmwjeineryYt5CWsDHjYN+rXZ8xYW+oXc4K5S4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780494799; c=relaxed/simple; bh=Pe0/nyaz42Pa0EfzhxkmJhiDip4+rKIwI3SR0E4erKU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LgVlw66QHWWAd0o26nW6AgHO0FtLXKLLzXdSj51azO7NOl6+mb6I/Y1iFoKAULA+Eqjdf8ltPfprb/Hlebv7IqccKyGB+hrhnrsQx6o7Fq8ZEF33pMvYn9Y9bGyKHKm59pkiN2LF0PsimtDaWMgbOdhoDCpSu4SO1GsFQL7d9hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jhjgfj2d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UKimW5Ia; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jhjgfj2d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UKimW5Ia" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653CTZKV1200016 for ; Wed, 3 Jun 2026 13:53:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iSDRVkC5HWAm8ddfs1//fWde9yiUBI8PwhpcLay7p1E=; b=Jhjgfj2dA9H1mxrE 7HeXuPqDmBGKvs+II19caBrRbgpUy210t0JtKA1OyA+tS3AsRUGZMWwy3HTgaFQp X0UCuK5eSIVVuRExGZk/hAlqYX60auzwFE2fZVTbQGZ43+YCAuvjZ/McYsFnrrNA Libbb0fL9phbZ02CrCgGfmpgFNJ2mOfYKnzBfhYSq8xhRv75Td7T48Jqe+A08FRi qnu2jXtOcy75DLDFjVZ9K4ESQUQHthKmZis2Vf/EOCLgsvsHJqTg16QIVcGyu6QF H7oNJ0IHqta105861AILwvsVfJ6hWnpoCQ3c84aHSKFa6WITH0n1q9rrRvuSWHdz z56G5w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejckw29hq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 13:53:16 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-915737aaf0bso74891585a.3 for ; Wed, 03 Jun 2026 06:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780494796; x=1781099596; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iSDRVkC5HWAm8ddfs1//fWde9yiUBI8PwhpcLay7p1E=; b=UKimW5IaTFu7aJVpXR8Y79pVNsRUC+OmlTBOdb+h5z7jKJNCYbs6tp9wOMINjWvlMx c/ThztdQyzCRE4YhUGdRjokaohhwyDezaVMy4Tg/5XwtMV43xjD1TREo+kbKnGxwIoWh tZga9yB0Hktd8vha2PexM2MBlcu9UKxwOztn+oG/cWmAclIJUvMuQz8lFiRJht4R7z5D GMeCDy+38swzvAzMr8iF7W8kJABCd80FE8OKWWatOi6PGavic3JC2HZx+IHhjaArz5Mq w/7xMMIOncchPdU8aEv0HUitleZrXnNNZ098tNdRAudV0s56wSESMNcw9L1xFpuXgyLc C+FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780494796; x=1781099596; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iSDRVkC5HWAm8ddfs1//fWde9yiUBI8PwhpcLay7p1E=; b=iovTJZbMWmNQ5UpRWPORBYdO/fOs24lBTqldXFC4F8QStenYu8FJAMycHB8I8CdY7R RV8MbMeE9pVBcb9+uP87aq2qX/e9flxwta45z5HB2BdEevJ2+azajwFKWvfZh3eQzFbu SueZ0UiC+CO2gnhKwWabXqu0Ej3Z0yFO3i2aY7Rh+EiNkcVAo/f6hYlwEc+rTjjYbfkT QvekVE23yuhdjnPvHmtd4fYo5ogPaF16B1s+4HePQoKHir9Yi8jLnPPWnfrWydCtVU+G 7JhukOA54P4q0z67+DmbarppmFAW2xosjhxUeV1o+rthZ7+7aPQ7WJ4xtjBmQ1FlHY2r 9VyA== X-Forwarded-Encrypted: i=1; AFNElJ+I3TTSCY76CoHQkc4uv+H0Dg+Rx5onk8E8t6dIlIDdptKLRdV31Gyu3iCKCHBS3K1EkG+mUeWBKWRaaP0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5QkfZ7STxsz1T5xZfJHouPFVxL4oh7Saydb51glzE9DvbljlX zajVC4N87yAi2crs4AuX9ugGrHF3bX+zgg/kWIw3gds9gTdCsMFDH/42WU1RgVuauovL0VIfzZI R2eZdhvZg8fUUXHf377Xz9t4VFfW6h8a5KsiUCjSCTUq6B7Lm2ZcxS0fekkNi0t5gup8= X-Gm-Gg: Acq92OHbWcP68F22W/LmxmgMuvvMMX0NLq1nuayb8neCOoGcE0laV8uDM+eyocOwfDp ye+FIcMB1wXAYwYB80O+Ehd0clOUhWooqsLesSOjtSgeIGU1HQQcVXdZZcCl+XBso20rqlAlyID IiZ7Mu9pBFVuMGxS6yKRUZoNa950xcTcjzARBtGHqh9ZCmBTtfwROlmXK1v2jZVvqHH6CNsXHN/ daK5H5I/jy7euLoOPLZE2F/oRp9zpW7iZkcr1qLaEpBSQ/Ps2WRk/SUgoyzXOdd4ZOVNtBUnDgv hl8Oc7UU8jPEnsUbMoPM3qMPZ+4Rt4RiPiXbLUmLQ3nB5TdHBOzWJrKxIrHElgoDxnm2g9HeDuD qKhXKCzQLLdL4h/OWJxdiVc1PFeouX1SPW5cK2wDBqsemZOWxA9SBdUO+nLFZ8XJhWaBmwYJiKD GiA26F1MBhizQ= X-Received: by 2002:a05:620a:2955:b0:8f3:5988:f97c with SMTP id af79cd13be357-9158a2c0f2dmr352296985a.3.1780494795482; Wed, 03 Jun 2026 06:53:15 -0700 (PDT) X-Received: by 2002:a05:620a:2955:b0:8f3:5988:f97c with SMTP id af79cd13be357-9158a2c0f2dmr352292485a.3.1780494795048; Wed, 03 Jun 2026 06:53:15 -0700 (PDT) Received: from [10.100.11.76] (public.toolboxoffice.it. [213.215.163.27]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64e2b79bsm1233851a12.8.2026.06.03.06.53.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 06:53:13 -0700 (PDT) Message-ID: <1de59ca1-0063-4ef4-b78d-acd7b3cbfabe@oss.qualcomm.com> Date: Wed, 3 Jun 2026 15:53:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] pinctrl: qcom: Modify MSM_PULL_MASK to accurately represent PULL bits To: Sneh Mankad , Bjorn Andersson , Linus Walleij , Yuanjie Yang Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260529-tlmm_test_changes-v1-0-88bfdccb4369@oss.qualcomm.com> <20260529-tlmm_test_changes-v1-1-88bfdccb4369@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260529-tlmm_test_changes-v1-1-88bfdccb4369@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: roCAwK6J1TVrMCYrp8RUzatvKKteTxni X-Authority-Analysis: v=2.4 cv=edUNubEH c=1 sm=1 tr=0 ts=6a2031cc cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=aBIYUfOEhgoR9egqXYNcqA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=qVY8_epACHd-z0WO0hwA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDEzMyBTYWx0ZWRfX8isfviRxcntP CNtNpfr9Y39TyQBrcf7aD7Svw/2OrJUd80suQx309agKEviUgrL+4XJcoYGCM3dmTNpY+se8nw+ gqLxW/oHXwT18zOYMI+rNS7DBZ2sRZWaEFwo3nFKoFnrwEQPA61lV2dQ2itVL2zg6AgkehUFEld 39NIHD5KMMSJw92Zq9RR7dsRWxhYfReuHR5pZnqC+viO1TVLRnSWboeaMXMOa6MX2HYz0FzUCt6 e0dklbFSD9ZE4EU+c2kgOYkjRb3NNg1SsyzZ9Pq4tiPcwUj2XeepjHwOaGw2UTEWrdtJ6MnnCjJ LJxFWgHdOjz5YFsfjtWmDD8z6LeA/z70B54oSkhUgnwpt1NTkJiACwzrDdaY1HurkZMYCxViA3b DShtAvCVCarT+7rusMEK1n2+Jfe2BwMTpXqqmJEgW2rZdarh4eTi+Is2xsrKCa9PZS4R6y60BUv UWgwJ6ojUcph6AiCb8A== X-Proofpoint-GUID: roCAwK6J1TVrMCYrp8RUzatvKKteTxni X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030133 On 29-May-26 14:55, Sneh Mankad wrote: > MSM_PULL_MASK currently spans bits [2:0], but the GPIO_PULL field in the > GPIO_CFG register only occupies bits [1:0]. Bit 2 belongs to > FUNC_SEL. > > MSM_PULL_MASK is used to isolate the GPIO_PULL bits before writing the > pull configuration (PULL_DOWN: 0x1, PULL_UP: 0x3) to the GPIO_CFG > register. Narrow it to bits [1:0] to prevent unintended modification of > the FUNC_SEL field. > > This causes no functional change since the driver currently does not > modify the FUNC_SEL bit, but align the mask with hardware configuration > nonetheless. > > Signed-off-by: Sneh Mankad > --- Seems to be the case down to MSM8960 indeed! Reviewed-by: Konrad Dybcio Konrad