From: Jon Hunter <jonathanh@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Prathamesh Shete <pshete@nvidia.com>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: thierry.reding@gmail.com, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, smangipudi@nvidia.com,
kyarlagadda@nvidia.com, Manish Bhardwaj <mbhardwaj@nvidia.com>
Subject: Re: [PATCH v3] gpio: tegra186: Check GPIO pin permission before access.
Date: Tue, 23 May 2023 07:22:18 +0100 [thread overview]
Message-ID: <1de5b7fb-a39e-183a-1407-7d6489f706b4@nvidia.com> (raw)
In-Reply-To: <CACRpkdYkJdZ67kyTnDg3xFzO8MJhC0nHK98O+KJwCLBqV_5f-Q@mail.gmail.com>
On 17/10/2022 10:31, Linus Walleij wrote:
> On Fri, Oct 7, 2022 at 7:59 AM Prathamesh Shete <pshete@nvidia.com> wrote:
>
>> This change checks if we have the necessary permission to
>> access the GPIO. For devices that have support for virtualisation
>> we need to check both the TEGRA186_GPIO_VM_REG and the
>> TEGRA186_GPIO_SCR_REG registers. For device that do not have
>> virtualisation support for GPIOs we only need to check the
>> TEGRA186_GPIO_SCR_REG register.
>>
>> Signed-off-by: Manish Bhardwaj <mbhardwaj@nvidia.com>
>> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
>
> Very nice patch!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I did not see this anywhere in the mainline/next. However, I also
noticed that we don't have the correct email address for Bartosz (again).
Bartosz, let me know if you can pick this up? Thierry also ack'ed
previously for Tegra too.
FWIW ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2023-05-23 6:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 12:21 [PATCH] " Prathamesh Shete
2022-09-14 13:22 ` Thierry Reding
2022-10-04 7:48 ` [PATCH v2] " Prathamesh Shete
2022-10-06 11:05 ` Thierry Reding
2022-10-07 5:59 ` [PATCH v3] " Prathamesh Shete
2022-10-07 10:25 ` Thierry Reding
2022-10-17 9:31 ` Linus Walleij
2023-05-23 6:22 ` Jon Hunter [this message]
2023-05-23 9:17 ` Bartosz Golaszewski
2023-05-23 13:42 ` Jon Hunter
2023-05-23 16:32 ` andy.shevchenko
2023-05-23 16:43 ` andy.shevchenko
2023-05-24 10:50 ` [PATCH v4] " Prathamesh Shete
2023-05-26 12:29 ` Bartosz Golaszewski
2022-09-14 13:43 ` [PATCH] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de5b7fb-a39e-183a-1407-7d6489f706b4@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=kyarlagadda@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mbhardwaj@nvidia.com \
--cc=pshete@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome