From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A055C2D0A3 for ; Wed, 4 Nov 2020 04:17:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C5C52236F for ; Wed, 4 Nov 2020 04:17:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728421AbgKDERC (ORCPT ); Tue, 3 Nov 2020 23:17:02 -0500 Received: from smtprelay0091.hostedemail.com ([216.40.44.91]:33970 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726008AbgKDERC (ORCPT ); Tue, 3 Nov 2020 23:17:02 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 65F6C100E7B42; Wed, 4 Nov 2020 04:17:01 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: screw82_3004fc0272be X-Filterd-Recvd-Size: 2346 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Wed, 4 Nov 2020 04:17:00 +0000 (UTC) Message-ID: <1de8953aba13bcd4c9643bae61af2081e33f071f.camel@perches.com> Subject: Re: [RFC PATCH] .clang-format: Remove conditional comments From: Joe Perches To: Miguel Ojeda Cc: clang-built-linux , LKML Date: Tue, 03 Nov 2020 20:16:59 -0800 In-Reply-To: References: <363325b4a85f094ba9cf06301dd022912ec79d03.camel@perches.com> <8d02497f4565c3154d3f7bcf2968b56ccd945ab4.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-11-04 at 04:57 +0100, Miguel Ojeda wrote: > On Wed, Nov 4, 2020 at 4:15 AM Joe Perches wrote: > > > > No one ever will use clang-format on the current kernel sources > > without having a recent version of clang and clang-format. > > Why? Many distros come with clang-format pre-packaged, and in fact the > original patch (that you commented on) argued for the >= 4 requirement > that way. The current kernel is v5.10 which requires clang 10.0 or higher. This patch is for the current kernel. This patch is not to be applied or backported to old kernels so no person is going to use this patch on any old or backported kernel. If a person is going to use clang-format on the current kernel sources unless they are developing for the current kernel. They are going to have to be using clang 10.0 or higher and therefore also will have and be using clang-format 10.0 or higher. Take it or not, apply it or not. I don't use clang-format and unless there are improvements to it, I imagine I'll continue to use emacs indent-region and a few other reformatting tools instead. cheers, Joe