From: wangkailong@jari.cn
To: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org
Cc: speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: [PATCH] speakup: Fix warning comparing pointer to 0
Date: Sun, 6 Nov 2022 23:07:54 +0800 (GMT+08:00) [thread overview]
Message-ID: <1de9cab8.c1.1844d7bdf4b.Coremail.wangkailong@jari.cn> (raw)
Fix the following coccicheck warning:
drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing
pointer to 0
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..5803b521df2b 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
else
snprintf(filename, sizeof(filename), "%s", name);
infile = fopen(filename, "r");
- if (infile == 0) {
+ if (infile) {
fprintf(stderr, "can't open %s\n", filename);
exit(1);
}
--
2.25.1
next reply other threads:[~2022-11-06 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 15:07 wangkailong [this message]
2022-11-06 15:51 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1de9cab8.c1.1844d7bdf4b.Coremail.wangkailong@jari.cn \
--to=wangkailong@jari.cn \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®