From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Hans de Goede <hansg@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Purism Kernel Team <kernel@puri.sm>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: Match DT value types
Date: Sat, 13 Jun 2026 09:47:30 +0200 [thread overview]
Message-ID: <1deb0868-7443-450f-9b08-68ce5d7ae7f6@kernel.org> (raw)
In-Reply-To: <20260612215308.1888834-1-robh@kernel.org>
On 12/06/2026 23:53, Rob Herring (Arm) wrote:
> The battery drivers read properties whose bindings use signed values
> for temperature thresholds and unsigned values for voltage thresholds.
> Some helpers used the opposite signedness, which makes property type
> checking report real mismatches.
>
> Use signed helpers where the binding and DTS allow negative values, and
> use unsigned helpers for voltage properties documented as uint32 cells.
>
> Assisted-by: Codex:gpt-5-5
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> drivers/power/supply/ltc2941-battery-gauge.c | 2 +-
> drivers/power/supply/max17042_battery.c | 8 ++++++--
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-06-13 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 21:53 Rob Herring (Arm)
2026-06-13 7:47 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1deb0868-7443-450f-9b08-68ce5d7ae7f6@kernel.org \
--to=krzk@kernel.org \
--cc=hansg@kernel.org \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh@kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®