From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42FA3ECDE44 for ; Thu, 25 Oct 2018 01:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4253207DD for ; Thu, 25 Oct 2018 01:47:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4253207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbeJYKRc (ORCPT ); Thu, 25 Oct 2018 06:17:32 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:52127 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726204AbeJYKRc (ORCPT ); Thu, 25 Oct 2018 06:17:32 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id F3C86E5250499; Thu, 25 Oct 2018 09:46:57 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.408.0; Thu, 25 Oct 2018 09:46:50 +0800 Subject: Re: [PATCH] f2fs: change segment to section in f2fs_ioc_gc_range To: Yunlong Song , , , CC: , , , , , References: <1540391736-20714-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <1dedda7c-edf5-82ae-787b-c2276e7c7275@huawei.com> Date: Thu, 25 Oct 2018 09:46:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1540391736-20714-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/24 22:35, Yunlong Song wrote: > f2fs_ioc_gc_range skips blocks_per_seg each time, however, f2fs_gc moves > blocks of section each time, so fix it from segment to section. I'm okay with this change, BTW, I notice that I need to change it to use sbi->blocks_per_seg * sbi->migration_granularity in my patchset if this patch being merged firstly. > > Signed-off-by: Yunlong Song > --- > fs/f2fs/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 88b1246..8c06724 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -2155,7 +2155,7 @@ static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg) > } > > ret = f2fs_gc(sbi, range.sync, true, GET_SEGNO(sbi, range.start)); > - range.start += sbi->blocks_per_seg; > + range.start += sbi->blocks_per_seg * sbi->segs_per_sec; use BLKS_PER_SEC() for cleanup? > if (range.start <= end) > goto do_more; > out: >