From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135A7C433E2 for ; Thu, 16 Jul 2020 06:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED0DC206F4 for ; Thu, 16 Jul 2020 06:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728248AbgGPGuH (ORCPT ); Thu, 16 Jul 2020 02:50:07 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:48851 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbgGPGuH (ORCPT ); Thu, 16 Jul 2020 02:50:07 -0400 Received: from [78.134.114.177] (port=35166 helo=[192.168.77.62]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1jvxiW-0007gd-82; Thu, 16 Jul 2020 08:50:04 +0200 Subject: Re: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and supplies To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl, leonl@leopardimaging.com, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1594787096-26685-1-git-send-email-skomatineni@nvidia.com> <1594787096-26685-2-git-send-email-skomatineni@nvidia.com> From: Luca Ceresoli Message-ID: <1df13fad-b5ce-3889-c240-3411e97598d2@lucaceresoli.net> Date: Thu, 16 Jul 2020 08:50:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1594787096-26685-2-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sowjanya, On 15/07/20 06:24, Sowjanya Komatineni wrote: > This patch adds IMX274 optional external clock input and voltage > supplies to device tree bindings. > > Signed-off-by: Sowjanya Komatineni > --- > Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt > index 80f2e89..ee427f5 100644 > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt > +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt > @@ -13,6 +13,11 @@ Required Properties: > > Optional Properties: > - reset-gpios: Sensor reset GPIO > +- clocks: Reference to the xclk clock. > +- clock-names: Should be "xclk". Not sure where the "xclk" name comes from, the datasheet I have calls the pin "CKIN". Maybe using the same name as the datasheet is better? Other than that looks good. -- Luca