From: Alex R <alex@ironrobin.net>
To: Stephan Gerhold <stephan.gerhold@linaro.org>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Steev Klimaszewski" <threeway@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] platform: arm64: Add Lenovo ThinkPad X13s EC driver
Date: Sat, 10 Oct 2026 15:06:59 +0000 [thread overview]
Message-ID: <1dfc1b67-3bcd-409f-9a9a-d9061abe76c9@ironrobin.net> (raw)
In-Reply-To: <asNZw4mFy_xOmCVD@linaro.org>
On 10/5/26 3:03 AM, Stephan Gerhold wrote:
> I'm mostly just curious, is the input/hotkey functionality in the T14s
> EC driver not relevant for the X13s or did you omit it because you don't
> need it and/or to keep the initial driver more simple? It seems to be
> present in the X13s ACPI similar to the T14s.
The X13s does have EC-generated hotkey events similar to the T14s.
I left the input functionality out intentionally to keep the initial
driver focused on keyboard-backlight control and power management.
I've identified several X13s event codes in the ACPI DSDT, including
the programmable F12 key and call-control keys. I think it makes sense
to add input support as a follow-up once the event mappings and
expected behavior have been verified on hardware.
Thanks,
Alex
next prev parent reply other threads:[~2026-10-10 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 15:42 [PATCH v5 0/3] Lenovo ThinkPad X13s embedded controller support Alex Robinson
2026-10-02 15:42 ` [PATCH v5 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad X13s EC Alex Robinson
2026-10-05 15:39 ` Rob Herring
2026-10-02 15:43 ` [PATCH v5 2/3] platform: arm64: Add Lenovo ThinkPad X13s EC driver Alex Robinson
2026-10-05 8:03 ` Stephan Gerhold
2026-10-10 15:06 ` Alex R [this message]
2026-10-02 15:43 ` [PATCH v5 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller Alex Robinson
2026-10-05 8:09 ` [PATCH v5 0/3] Lenovo ThinkPad X13s embedded controller support Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfc1b67-3bcd-409f-9a9a-d9061abe76c9@ironrobin.net \
--to=alex@ironrobin.net \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephan.gerhold@linaro.org \
--cc=threeway@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®