From: Markus Elfring <Markus.Elfring@web.de>
To: Junyi Zhao <junyi.zhao@amlogic.com>,
Xianwei Zhao <xianwei.zhao@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver
Date: Wed, 18 Nov 2026 10:40:58 +0100 [thread overview]
Message-ID: <1e02da75-0833-4a47-b190-cbc9f5346a86@web.de> (raw)
In-Reply-To: <20261118-a9-i2c-v11-2-68a3e79ff43a@amlogic.com>
…
> +++ b/drivers/i2c/busses/i2c-amlogic-a9.c
> @@ -0,0 +1,428 @@
…
> +static int aml_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> +{
> + struct aml_i2c *i2c = adap->algo_data;
> + int i, ret = 0;
How do you think about to omit the initialisation for the variable “ret”
in such a function implementation?
> +
> + for (i = 0; i < num; i++) {
> + ret = aml_i2c_xfer_msg(i2c, msgs + i, i == num - 1);
> + if (ret)
> + return ret;
> + }
> +
> + return i;
> +}
…
Regards,
Markus
prev parent reply other threads:[~2026-11-18 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 7:17 [PATCH v11 0/2] i2c: Add driver support Amlogic A9 I2C Xianwei Zhao via B4 Relay
2026-11-18 7:17 ` [PATCH v11 1/2] dt-bindings: i2c: add Amlogic A9 I2C controller Xianwei Zhao via B4 Relay
2026-11-18 7:17 ` [PATCH v11 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Xianwei Zhao via B4 Relay
2026-11-18 9:40 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e02da75-0833-4a47-b190-cbc9f5346a86@web.de \
--to=markus.elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=junyi.zhao@amlogic.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®