From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA58C4167B for ; Tue, 12 Dec 2023 13:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346408AbjLLN1N (ORCPT ); Tue, 12 Dec 2023 08:27:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232253AbjLLN1M (ORCPT ); Tue, 12 Dec 2023 08:27:12 -0500 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D4C9EB; Tue, 12 Dec 2023 05:27:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702387636; bh=xDgSLNOEDoRbx3eokyLAR16GqDH2Uv/Z7DBLvAgMnGg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WwNIE1XK3CLrmcACMu8onN3StZKF02LFMGr5o8eV8qZKQ95qO1394/W7wFymVt/Gv NkzR7gbMzj1tKHer8FN2c3/cXgLdj1kkoUv2/5tUIpTbm34fbyUSq0HftfnnNH3lJU awuTCSDgv2y2LUGmmKRXrqxvBNR2hJFs/g7InuAA1IeqN2GhcAUpmIHivkjXJKIIqd +Giz0c7dI2j3PZ61m/57b2R5OjTiKfqWfi9lUow0b8heqUaEOhJYk2B+UN9C0Vj9aV r37GQLFxz1yYQ05ytLQVo1FmW5hhJkqe13aElSSMa5d6mMP/Wi0PQTDIvlY1epOqM5 +DBu82DsKRVPQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id DEE23378143B; Tue, 12 Dec 2023 13:27:15 +0000 (UTC) Message-ID: <1e05cb3e-3ef2-45ca-9754-add6d0e185f0@collabora.com> Date: Tue, 12 Dec 2023 14:27:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 17/17] drm/mediatek: Add comments for the structures Content-Language: en-US To: Hsiao Chien Sung , Chun-Kuang Hu , CK Hu Cc: Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chen-Yu Tsai , Sean Paul , Fei Shao , Bibby Hsieh , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231212121957.19231-1-shawn.sung@mediatek.com> <20231212121957.19231-18-shawn.sung@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231212121957.19231-18-shawn.sung@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: > Add comments for the structures to improve readability. > > Signed-off-by: Hsiao Chien Sung > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++++++++++++- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 22 ++++++++++++-- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 32 +++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 15 ++++++++++ > drivers/gpu/drm/mediatek/mtk_ethdr.c | 11 +++++++ > 5 files changed, 97 insertions(+), 4 deletions(-) > ..snip.. > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > index 38d08796fae4..af80c9e50d36 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > @@ -46,6 +46,38 @@ enum mtk_ddp_comp_type { > > struct mtk_ddp_comp; > struct cmdq_pkt; > + > +/* struct mtk_ddp_comp_funcs - function pointers of the ddp components > + * @clk_enable: enable the clocks of the component > + * @clk_disable: disable the clocks of the component > + * @config: configure the component > + * @start: start (enable) the component > + * @stop: stop (disable) the component > + * @register_vblank_cb: to register a callback function when vblank irq occurs > + * @unregister_vblank_cb: to unregister the callback function from the vblank irq > + * @enable_vblank: enable vblank irq > + * @disable_vblank: disable vblank irq > + * @supported_rotations: return rotation capability of the component > + * @layer_nr: how many layers the component supports > + * @layer_check: to check if the state of the layer is valid for the component > + * @layer_config: to configure the component according to the state of the layer > + * @gamma_set: to set gamma for the component > + * @bgclr_in_on: turn on background color > + * @bgclr_in_off: turn off background color > + * @ctm_set: set color transformation matrix > + * @dma_dev_get: return the device that uses direct memory access > + * @get_formats: get the format that is currently in use by the component > + * @get_num_formats: get number of the formats that the component supports > + * @connect: connect the sub modules of the component > + * @disconnect: disconnect the sub modules of the component > + * @add: add the device to the component (mount them in the mutex) > + * @remove: remove the device from the component (unmount them from the mutex) > + * @encoder_index: get the encoder index of the component > + * @crc: return the start of crc array > + * @crc_cnt: how many CRCs the component supports > + * @crc_entry: get the pointer to the crc entry > + * @crc_read: call this function to read crc from the hardware component > + */ > struct mtk_ddp_comp_funcs { > int (*power_on)(struct device *dev); > void (*power_off)(struct device *dev); Please rebase over the latest upstream kernel, as it doesn't apply like this. After which: Reviewed-by: AngeloGioacchino Del Regno