From: "Mario Limonciello (AMD) (kernel.org)" <superm1@kernel.org>
To: Rong Zhang <i@rong.moe>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/CPU/AMD: Prevent reset reasons from being retained among boots
Date: Sun, 28 Sep 2025 23:01:52 -0500 [thread overview]
Message-ID: <1e07144c-da10-4817-a2c6-ea11988936ee@kernel.org> (raw)
In-Reply-To: <20250916140227.GGaMlt8xSp3eMI8Veu@fat_crate.local>
On 9/16/2025 9:02 AM, Borislav Petkov wrote:
> On Sat, Sep 13, 2025 at 10:42:45PM +0800, Rong Zhang wrote:
>> The S5_RESET_STATUS register is parsed on boot and printed to kmsg.
>> However, this could sometimes be misleading and lead to users wasting a
>> lot of time on meaningless debugging for two reasons:
>>
>> * Some bits are never cleared by hardware. It's the software's
>> responsibility to clear them as per the Processor Programming Reference
>> (see Link:).
>>
>> * Some rare hardware-initiated platform resets do not update the
>> register at all.
>>
>> In both cases, a previous reboot could leave its trace in the register,
>> resulting in users seeing unrelated reboot reasons while debugging
>> random reboots afterward.
>
> Just a heads-up: we're figuring out internally what the right thing to do here
> would be.
>
> Stay tuned.
>
> Thx.
>
The internal conversation points in the direction of your patch makes sense.
But I don't really see a lot of value in re-reading and printing a debug
message about what was cleared and what's still there. Do you see a
reason to keep that around?
next prev parent reply other threads:[~2025-09-29 4:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 14:42 Rong Zhang
2025-09-16 14:02 ` Borislav Petkov
2025-09-29 4:01 ` Mario Limonciello (AMD) (kernel.org) [this message]
2025-09-30 10:18 ` Rong Zhang
2025-10-06 13:31 ` Borislav Petkov
2025-10-06 17:07 ` Rong Zhang
2025-10-06 21:41 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e07144c-da10-4817-a2c6-ea11988936ee@kernel.org \
--to=superm1@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=i@rong.moe \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®