From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A22AC10F0E for ; Fri, 12 Apr 2019 19:06:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAA682171F for ; Fri, 12 Apr 2019 19:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555095985; bh=TPyXzxpNCFg8DH4jzTgBnGYcFVIJNGmCk/REZ+s49IM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=x1+7bgf7wvI339biHTk/RrNKqJXjrsKyol9E86/PY4UMmTEo3KcbtFl7hasjjgZnk PoV/h3MRNmXT5gX2CmSOASVKd6W54Et9Mhsw89pbhniSu0XziLQn59hGfv8yFfAvFe WWLqexynp5nZq6vNPwGFLiizxT1EHNJzgPwB2yuA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726959AbfDLTGY (ORCPT ); Fri, 12 Apr 2019 15:06:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:36496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726765AbfDLTGY (ORCPT ); Fri, 12 Apr 2019 15:06:24 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9BDC20818; Fri, 12 Apr 2019 19:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555095983; bh=TPyXzxpNCFg8DH4jzTgBnGYcFVIJNGmCk/REZ+s49IM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=S/e9nKOI8cxbFevPNFW5xNh+F6oqMwRSlZ+IPZsqshZz4Ie3N4yKEHZsMHH4HE7RA amyM9Gn7PtQ9mtPxACvnialX+v0rBQiZFOxU79jzD4LsR5YIHpmep3HgSQssWAWtg5 c2yPaHRpWkakk3GtD/fRtMT87XL0qKGQvbdyABKQ= Subject: Re: [PATCH] selftests: livepatch use TEST_PROGS for test shell scripts To: Joe Lawrence , Miroslav Benes Cc: jpoimboe@redhat.com, jikos@kernel.org, pmladek@suse.com, live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, shuah References: <20190412011823.26884-1-shuah@kernel.org> <8967c9aa-7eb1-7e6d-a371-f29a2be24c84@kernel.org> <6f97800f-e78f-7d16-32b2-96ee5260321c@redhat.com> From: shuah Message-ID: <1e07dae8-6699-6b72-1508-2b6b89d3d92d@kernel.org> Date: Fri, 12 Apr 2019 13:06:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6f97800f-e78f-7d16-32b2-96ee5260321c@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/19 12:51 PM, Joe Lawrence wrote: > On 4/12/19 1:05 PM, shuah wrote: >> On 4/12/19 7:37 AM, Miroslav Benes wrote: >>> On Fri, 12 Apr 2019, shuah wrote: >>> >>>> On 4/12/19 1:03 AM, Miroslav Benes wrote: >>>>> On Thu, 11 Apr 2019, Shuah Khan wrote: >>>>> >>>>>> TEST_PROGS variable is for test shell scripts and common clean target >>>>>> in lib.mk doesn't touch them. TEST_GEN_PROGS are removed by it. >>>>>> >>>>>> Fix it to use TEST_PROGS for test shell scripts and >>>>>> TEST_PROGS_EXTENDED >>>>>> for common functions.sh. >>>>>> >>>>>> Signed-off-by: Shuah Khan >>>>>> --- >>>>>>     tools/testing/selftests/livepatch/Makefile | 3 ++- >>>>>>     1 file changed, 2 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/tools/testing/selftests/livepatch/Makefile >>>>>> b/tools/testing/selftests/livepatch/Makefile >>>>>> index af4aee79bebb..fd405402c3ff 100644 >>>>>> --- a/tools/testing/selftests/livepatch/Makefile >>>>>> +++ b/tools/testing/selftests/livepatch/Makefile >>>>>> @@ -1,6 +1,7 @@ >>>>>>     # SPDX-License-Identifier: GPL-2.0 >>>>>> -TEST_GEN_PROGS := \ >>>>>> +TEST_PROGS_EXTENDED := functions.sh >>>>>> +TEST_PROGS := \ >>>>>>      test-livepatch.sh \ >>>>>>      test-callbacks.sh \ >>>>>>      test-shadow-vars.sh >>>>> >>>>> Hi Shuah, >>>>> >>>>> thanks for the patch. We have already something similar queued in >>>>> our git >>>>> tree. See >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git/commit/?h=for-5.1/upstream-fixes&id=abfe3c4560684864f66641438fee3075de098e89 >>>>> >>>>> >>>>> It is missing TEST_PROGS_EXTENDED though. Should we add it? >>>>> >>>> >>>> Please do. What that does is when selftests are installed, functions.h >>>> gets installed as well so the the test can run from installed location. >>>> >>>> Did I miss reviewing the original? I maintain the framework and try to >>>> catch these if patch gets sent to me. >>> >>> Unfortunately you did and it was our fault. You were not CCed, no one >>> noticed and we were a bit trigger happy. Sorry about that. It should not >>> have happened. >>> >>> Would this work for you? >> >> Looks good to me. >> > > Hi Shuah, > > Thanks for spotting this and apologies for missing your CC on my earlier > patch post.  For future reference, do you prefer a direct CC, > linux-kselftest, or both? No worries. Happy to report the problem. Couldn't have missed it with all the deleted lines showing up whenever I ran diff on my changes. :) Direct to or cc to me and cc linux-kselftest list is preferred Same as any other patch really, everybody getmaintainer.pl recommends. thanks, -- Shuah