mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	James Bottomley <JBottomley@Parallels.com>
Cc: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1
Date: Thu, 12 Dec 2024 23:20:42 +0100	[thread overview]
Message-ID: <1e0eb9ca-6edc-4ce7-b62f-d34ca254fe52@molgen.mpg.de> (raw)
In-Reply-To: <20241212221817.78940-2-pmenzel@molgen.mpg.de>

[Remove non-working @lsi.com addresses]

Am 12.12.24 um 23:18 schrieb Paul Menzel:
> Currently, the code does:
> 
>      if (x == 0) {
>      	x &= ~0x3;
> 	x |= 0x1;
>      }
> 
> Zeroing bits 0 and 1 of a variable that is 0 is not necessary. So
> directly set the variable to 1.
> 
> Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
> Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS")
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>   drivers/scsi/mpt3sas/mpt3sas_base.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 87fcafce947c..2cd0bb606d88 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -5629,8 +5629,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc)
>   	if (!ioc->is_gen35_ioc && ioc->manu_pg11.EEDPTagMode == 0) {
>   		pr_err("%s: overriding NVDATA EEDPTagMode setting from 0 to 1.\n",
>   		    ioc->name);
> -		ioc->manu_pg11.EEDPTagMode &= ~0x3;
> -		ioc->manu_pg11.EEDPTagMode |= 0x1;
> +		ioc->manu_pg11.EEDPTagMode = 0x1;
>   		mpt3sas_config_set_manufacturing_pg11(ioc, &mpi_reply,
>   		    &ioc->manu_pg11);
>   	}

  reply	other threads:[~2024-12-12 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 22:18 [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Paul Menzel
2024-12-12 22:18 ` [PATCH 2/2] scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1 Paul Menzel
2024-12-12 22:20   ` Paul Menzel [this message]
2025-01-02 18:45   ` Martin K. Petersen
2025-01-02 18:45 ` [PATCH 1/2] scsi: mpt3sas: Add details to EEDPTagMode error message Martin K. Petersen
2025-01-10 21:16 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e0eb9ca-6edc-4ce7-b62f-d34ca254fe52@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=JBottomley@Parallels.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®