mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Like Xu <like.xu.linux@gmail.com>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: seanjc@google.com, jmattson@google.com,
	dave.hansen@linux.intel.com, peterz@infradead.org,
	alexander.shishkin@linux.intel.com, eranian@google.com,
	daviddunn@google.com, ak@linux.intel.com,
	kan.liang@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, kim.phillips@amd.com,
	santosh.shukla@amd.com,
	"Paolo Bonzini - Distinguished Engineer (kernel-recipes.org)
	(KVM HoF)"  <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] KVM: x86/pmu: Segregate Intel and AMD specific logic
Date: Mon, 21 Feb 2022 15:57:05 +0800	[thread overview]
Message-ID: <1e0fc70a-1135-1845-b534-79f409e0c29d@gmail.com> (raw)
In-Reply-To: <20220221073140.10618-4-ravi.bangoria@amd.com>

On 21/2/2022 3:31 pm, Ravi Bangoria wrote:
>   void reprogram_counter(struct kvm_pmu *pmu, int pmc_idx)
>   {
>   	struct kvm_pmc *pmc = kvm_x86_ops.pmu_ops->pmc_idx_to_pmc(pmu, pmc_idx);
> +	bool is_intel = !strncmp(kvm_x86_ops.name, "kvm_intel", 9);

How about using guest_cpuid_is_intel(vcpu) directly in the reprogram_gp_counter() ?

  reply	other threads:[~2022-02-21  7:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21  7:31 [PATCH 0/3] " Ravi Bangoria
2022-02-21  7:31 ` [PATCH 1/3] x86/pmu: Add INTEL_ prefix in some Intel specific macros Ravi Bangoria
2022-02-21  7:31 ` [PATCH 2/3] x86/pmu: Replace X86_ALL_EVENT_FLAGS with INTEL_ALL_EVENT_FLAGS Ravi Bangoria
2022-02-21  7:31 ` [PATCH 3/3] KVM: x86/pmu: Segregate Intel and AMD specific logic Ravi Bangoria
2022-02-21  7:57   ` Like Xu [this message]
2022-02-21 10:01     ` Ravi Bangoria
2022-03-03  4:38       ` Jim Mattson
2022-03-03 16:25         ` Ravi Bangoria
2022-03-03 18:05           ` Jim Mattson
2022-03-04  9:33             ` Like Xu
2022-03-05  3:29               ` Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e0fc70a-1135-1845-b534-79f409e0c29d@gmail.com \
    --to=like.xu.linux@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=daviddunn@google.com \
    --cc=eranian@google.com \
    --cc=jmattson@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=kim.phillips@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=santosh.shukla@amd.com \
    --cc=seanjc@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®