From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9E621EB5B for ; Sun, 29 Dec 2024 15:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735484483; cv=none; b=XOJUe/Mnr6KFpRFM2GqvQNTOOvFawszKwPGRxw4NeBqIiTHQBHvv32knPAS6drvZL27wYHhSA8rnQ5QRLLkeGIu8u6fvp9252xyNqcP+7zr550GHZjCxzE79+5DiXeRP41jfk445kmu4adIOIyPkw9JgSBllRr3Kb9h52ElDAfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735484483; c=relaxed/simple; bh=F8Ss49pFUCgBaRKXk6NhT0tEHPQZbWxAzH8oy2pT3lk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U609ru2LJcAThHY0BbUxiVPblohPqMQ8cuAd+AzXY2J7u/KrOoiQZDI+vl1Z8g9ui2dyoxxPXhWzVDYtxuGhfZjz2DH8gVSemG+lzraDtOe4MLYyiy0UtwfKYF+zuKZPbv6tubBdS3w8wcSVEfS4jLw3EccIR1GDkBmFZT+80Bw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=HvObE2TV; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="HvObE2TV" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BTCRJQV016737; Sun, 29 Dec 2024 15:01:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=wCsKj2 QOObw+fJoFNyPGKQuWkj9ZTSu+UzQ7CGaXLbg=; b=HvObE2TVzb9twzvN/gwAms tPSxTv7g5GlNMwRM4yNDha4BSExqpDVSt+X4cxLYQw/Fv6UDn/QSrXxlgp68sOPQ 0BT6xJoPIQdZ+a/Zn+wKci2zVq1Tdh77NVHSvCOCbiynQGIVyoHIYi2Sj1wU5fNt 3lz3uX84NGLHmC+3MMkatKkkLuNkfsu3e2tw0DFrDzEhyT/5qsRCmfJCcr/nZHfP uEzypvHU8ifgQUkmy15mEXRkSdWQzYC8D0O/vR28ndjq7VSrgf47SWPQ1bnKfVZg 89hchCmmRrmbasPmNypIL9nCuQq3bwOiScw5/gD7BHA+B1DP3T2BEjalUzLUAadg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43u2m28rev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 15:01:05 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BTExTRP026700; Sun, 29 Dec 2024 15:01:05 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43u2m28res-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 15:01:05 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BTCbVFk014606; Sun, 29 Dec 2024 15:01:04 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43tunsa52q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2024 15:01:04 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BTF13YX29885024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Dec 2024 15:01:03 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F51058054; Sun, 29 Dec 2024 15:01:03 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F41AE5804E; Sun, 29 Dec 2024 15:00:57 +0000 (GMT) Received: from [9.171.1.162] (unknown [9.171.1.162]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 29 Dec 2024 15:00:57 +0000 (GMT) Message-ID: <1e103f72-01e0-4187-bb55-c9bd8f17eec2@linux.ibm.com> Date: Sun, 29 Dec 2024 20:30:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-6-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: CqAg9N1_bCqD0injjVLDojONhPTrAAbZ X-Proofpoint-ORIG-GUID: KMBSt-LSqk9ymqEHJNxx7kVo69B2mwiR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=526 suspectscore=0 impostorscore=0 mlxscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412290134 On 12/27/24 21:26, Gregory Price wrote: > On Fri, Dec 27, 2024 at 04:31:48PM +0530, Donet Tom wrote: >>> folio_clear_referenced(folio); >>> workingset_activation(folio); >>> + } else { >>> + >> In the current implementation, promotion will not work if we enable MGLRU, >> right? >> Is there any specific reason we are not enabling promotion with MGLRU? >> > folio_mark_accessed may not be the best place to interpose for MGLRU, > since MGLRU's semantics are so different. I didn't want to dive that > deep until I could show traditional LRU benefit. > > Certainly open to ideas if you're familiar with MGLRU semantics. Thanks. I will take a look at it. > > ~Gregory >