From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793959113; b=NpLg7M5JZ/2xoDX6y1GAZqLSx6MPVYqvphjRiNTYe2kt4yEf3O5RW87uqgrBk3AErLb/ MUZQ/bDj8656M4oUFnu+f5r/0E2on9Pdpy5VKFo+4paQyGyDWrIcwbtPPVfYdglwiGYWR NiUVMsgzAzV/p3A1wbgKjZ0VQvhRWgI1D4g56z52jwZX/PSU5ec1XMmRfhvaHdmBcemoU 7NP7dizGi4K9i7gsbugqTxvMn1gmPW6D7TQSPIozlCV1yTf6EsfGr+2uwmQiPIJvAv+F7 gvuFFefDhztAZyDDYP/eSqBdvOaBm9md8yRM35Wfc6AOsMx43epuMJiD6AiQbxX80lQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793959113; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=kbFOWcR5A6GDWO1RwMhPHFn30qJ8DBxtRSmC21gCtx4=; b=oyIclmmMrhUytxhJWHexsm5Zek/SbYb3yl/hQGdUJuLZimJwawzETRUwj8wYw9bYPRbR Y1IZ1ONVhW6wAoV6wdDSclxqn+RATW/zsV4fomXq3jp8JwgS0G/qmiwFFHnIQxolQxhNE pEPwAIUJDBld2hSRBvDqAUX6fz3XOGE1ds/T41NuCnpga9iHgIv+s6x/lwQrjLthglFMw btmisNDpdK1G1q+L6eo4rQ2qhM30bzuSHsLV0YTiZOLp9wO4TFQTqGbDMvYomx7VoZRXK ODH2lJQemm+An0TzpdkbZTJ2HaC18ni/sY6/dwvdaAL518VgrgyEl6LHWCLkAZfgQ6A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=tcvCobbY; arc=none smtp.remote-ip=185.246.85.4 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46258606A326 for ; Fri, 6 Nov 2026 09:58:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 46258606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=tcvCobbY Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 5ECF54E413F4; Fri, 6 Nov 2026 09:58:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 1B4EA5FFBC; Fri, 6 Nov 2026 09:58:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2BA12103291F9; Fri, 6 Nov 2026 10:58:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1793959104; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=kbFOWcR5A6GDWO1RwMhPHFn30qJ8DBxtRSmC21gCtx4=; b=tcvCobbYjIy6MNOP2TZqIe7RrPmlVaebdIin+t8AfwE/41bMrqrla3DBS9z9LQQQESELE1 dkoOfHDwF+Q1ZnOPqvI6/n5Lvzwh8s3rdV9KSfSzczS6mwwjM+pVQt2VA0pzESp2teTxdm KE3imiAZSUXihBW8LJ4UmGJlcSe6FX2989eLUTfqo+PaUzx0mi2aj7kcTQJy6TBLiBcpav nP9xslvjHOkOh6Xq0WxtWUCMkvLq9Fz8LAmv2ESPxceLVSSIP980DIjZazGdaedDOucMZa 1PUTFIr6QnqCp+nXdvFdL6c0UzT/Ku8sYE7A5sTYD8FelifqE4hnBIJ6TFByiw== Message-ID: <1e12523f-a294-4f98-93d9-4ea3479d4456@bootlin.com> Date: Fri, 6 Nov 2026 10:58:17 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mfd: Use named initializers for acpi_device_id To: Pawel Zalewski , Lee Jones , Chen-Yu Tsai , David Rhodes , Richard Fitzgerald , Andy Shevchenko , Mika Westerberg , Zha Qipeng , Qunqin Zhao , Andy Shevchenko Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-crypto@vger.kernel.org, Charles Keepax References: <20261104-acpi-mfd-v2-0-64b9dee3baaf@thegoodpenguin.co.uk> <20261104-acpi-mfd-v2-2-64b9dee3baaf@thegoodpenguin.co.uk> Content-Language: en-US From: Thomas Richard In-Reply-To: <20261104-acpi-mfd-v2-2-64b9dee3baaf@thegoodpenguin.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 11/4/26 5:09 PM, Pawel Zalewski wrote: > Use a designated initializer for the acpi_device_id fields which makes the > code more readable and consistent with how lists are initialized in the > rest of the kernel code base. Also drop explicitly setting fields to 0 > where it is redundant. > > Unify the list terminator to have a single space between the brackets and > no trailing comma. > > Reviewed-by: Charles Keepax > Signed-off-by: Pawel Zalewski > --- > drivers/mfd/axp20x-i2c.c | 2 +- > drivers/mfd/cs42l43-i2c.c | 8 ++++---- > drivers/mfd/intel_pmc_bxt.c | 2 +- > drivers/mfd/intel_soc_pmic_bxtwc.c | 2 +- > drivers/mfd/intel_soc_pmic_chtdc_ti.c | 4 ++-- > drivers/mfd/intel_soc_pmic_chtwc.c | 2 +- > drivers/mfd/intel_soc_pmic_crc.c | 4 ++-- > drivers/mfd/intel_soc_pmic_mrfld.c | 4 ++-- > drivers/mfd/kempld-core.c | 6 +++--- > drivers/mfd/loongson-se.c | 2 +- > drivers/mfd/upboard-fpga.c | 6 +++--- Acked-by: Thomas Richard # upboard-fpga.c Best Regards, Thomas