From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH] thermal: core: Print out thermal zone name on update_temperature error
Date: Tue, 19 Dec 2023 12:48:45 +0100 [thread overview]
Message-ID: <1e151dcf-d4fc-4aec-9f68-c8ef372a00f2@linaro.org> (raw)
In-Reply-To: <CAJZ5v0gkko7nWH2ePwEhbfXR-jAb9+f+rsfYXKBMSz04uW4rYg@mail.gmail.com>
On 18.12.2023 20:40, Rafael J. Wysocki wrote:
> On Mon, Dec 18, 2023 at 3:40 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> Currently, we can encounter an error like this:
>>
>> thermal thermal_zone48: failed to read out thermal zone (-19)
>>
>> It's good to know that there's been an issue, but on some occasions
>> (like the error happening in the middle of a platform crash), one may
>> not be able to look up what kind of thermal zone that is.
>>
>> Add the TZ name to the error message in order to speed up debugging.
>
> s/name/type/ ? It looks like that's what you mean.
>
> First, the tz type is not its name (because there may be multiple
> zones of the same type) and it would be consistent with the first
> paragraph above.
That's possible, I'm no expert wrt thermal :)
Would you be okay with this change, together with an amended commit
message?
Konrad
next prev parent reply other threads:[~2023-12-19 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 14:40 Konrad Dybcio
2023-12-18 19:40 ` Rafael J. Wysocki
2023-12-19 11:48 ` Konrad Dybcio [this message]
2023-12-19 12:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e151dcf-d4fc-4aec-9f68-c8ef372a00f2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=marijn.suijten@somainline.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®