From: Leon Romanovsky <leon@kernel.org>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Alexander Lobakin <alobakin@pm.me>,
Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
Ariel Elior <aelior@marvell.com>,
GR-everest-linux-l2@marvell.com,
GR-QLogic-Storage-Upstream@marvell.com,
Igor Russkikh <irusskikh@marvell.com>,
intel-wired-lan@lists.osuosl.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Javed Hasan <jhasan@marvell.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jiri Pirko <jiri@nvidia.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Michael Chan <michael.chan@broadcom.com>,
Michal Kalderon <michal.kalderon@marvell.com>,
netdev@vger.kernel.org, Sathya Perla <sathya.perla@broadcom.com>,
Saurav Kashyap <skashyap@marvell.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Subject: [PATCH net-next 5/6] ice: Delete always true check of PF pointer
Date: Thu, 23 Sep 2021 21:12:52 +0300 [thread overview]
Message-ID: <1e19cd378b76b891acd4cff122b622fdb0f99ed0.1632420431.git.leonro@nvidia.com> (raw)
In-Reply-To: <cover.1632420430.git.leonro@nvidia.com>
From: Leon Romanovsky <leonro@nvidia.com>
PF pointer is always valid when PCI core calls its .shutdown() and
.remove() callbacks. There is no need to check it again.
Fixes: 837f08fdecbe ("ice: Add basic driver framework for Intel(R) E800 Series")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 34e64533026a..aacc0b345bbe 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -4593,9 +4593,6 @@ static void ice_remove(struct pci_dev *pdev)
struct ice_pf *pf = pci_get_drvdata(pdev);
int i;
- if (!pf)
- return;
-
for (i = 0; i < ICE_MAX_RESET_WAIT; i++) {
if (!ice_is_reset_in_progress(pf->state))
break;
--
2.31.1
next prev parent reply other threads:[~2021-09-23 18:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 18:12 [PATCH net-next 0/6] Batch of devlink related fixes Leon Romanovsky
2021-09-23 18:12 ` [PATCH net-next 1/6] bnxt_en: Check devlink allocation and registration status Leon Romanovsky
2021-09-23 21:11 ` Edwin Peer
2021-09-23 23:11 ` Leon Romanovsky
2021-09-24 1:39 ` Jakub Kicinski
2021-09-24 17:20 ` Edwin Peer
2021-09-25 10:01 ` Leon Romanovsky
2021-09-23 18:12 ` [PATCH net-next 2/6] bnxt_en: Properly remove port parameter support Leon Romanovsky
2021-09-23 21:23 ` Edwin Peer
2021-09-23 18:12 ` [PATCH net-next 3/6] devlink: Delete not used port parameters APIs Leon Romanovsky
2021-09-23 18:12 ` [PATCH net-next 4/6] devlink: Remove single line function obfuscations Leon Romanovsky
2021-09-23 18:12 ` Leon Romanovsky [this message]
2021-09-23 18:12 ` [PATCH net-next 6/6] qed: Don't ignore devlink allocation failures Leon Romanovsky
2021-09-23 22:55 ` [PATCH net-next 0/6] Batch of devlink related fixes Jakub Kicinski
2021-09-23 23:16 ` Leon Romanovsky
2021-09-24 13:14 ` David Miller
2021-09-25 8:56 ` Leon Romanovsky
2021-09-24 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e19cd378b76b891acd4cff122b622fdb0f99ed0.1632420431.git.leonro@nvidia.com \
--to=leon@kernel.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=alobakin@pm.me \
--cc=anirudh.venkataramanan@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=irusskikh@marvell.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jejb@linux.ibm.com \
--cc=jesse.brandeburg@intel.com \
--cc=jhasan@marvell.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.chan@broadcom.com \
--cc=michal.kalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=skashyap@marvell.com \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®