From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934785AbdEVOdU (ORCPT ); Mon, 22 May 2017 10:33:20 -0400 Received: from mout.web.de ([212.227.15.14]:56952 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933917AbdEVOdQ (ORCPT ); Mon, 22 May 2017 10:33:16 -0400 Subject: Re: RDS: TCP: Delete an error message for a failed memory allocation in rds_tcp_init_net() To: Sowmini Varadhan , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, kernel-janitors@vger.kernel.org Cc: "David S. Miller" , Santosh Shilimkar , LKML References: <44b46c51-3665-5f14-dd3b-6e6f230258a7@users.sourceforge.net> <5d523cf8-1540-e704-2301-a5e0205cb536@users.sourceforge.net> <20170522142651.GA29434@oracle.com> From: SF Markus Elfring Message-ID: <1e1a5d08-34a7-1b88-80ac-c650c4ae76cf@users.sourceforge.net> Date: Mon, 22 May 2017 16:32:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170522142651.GA29434@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:zmm8nv+3Uu7vnDognh5pe8VO9a4I6SgZV3AxCKWwAfk/VWidYQT PnBjswOwdUfnkLwJTnlXPIjLjcXp5mxLabEEy+w50A05lEF4SRxYp50tMEON8HFdR9UNjAH 84YJvrshJ9uu1iabq2CCgdr0j7Xds9tmx87/IUtD5iY2oL+Rs89TOg6rcqT6KmcFFIqoPSP O92o1FswxmcnFgnW9tcrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:xtKUo7C3WS4=:3iMZAJ2aNvYsrKTyC9CVRz 41DqQmW+4gNZjdJ47S+VtkIwTmoJWIBdtZ5i9p3TcQAlXCzXXxf2yOblrdS8EWk6T+E+h5Fsp 1rKjsAoIJZlwpScK1YYOIAtP/cKjnznfq3gXrcGAeU67SXR/Oq9NMwaGGTgafqCuYB6dEvRAV XdOmq0qn8NBsosgumW5HbfOwakDDUV8fmnapdsvFypf7g+aqTrYXSArLmHerAdTIn6cELfVzS uMmSbBWOAXqpaiBnLkMvwXlFiei822xGqVb6HKCytuf1bw6nHMiQ5NBapXKfMvOFrg94A/gqS 8by0w/Tr6jiyh/WwQEufAGY1wcLU5T072c/sEkiR/m0bEDr57ouyY4WRycXj+jNbYY2moOJfn qY+TVu/7c7+jLLFYVx/lEvibscTmcwm/6lOt9eP8bitHS6ibOzmt09ma1Fp2WP+h1KYR63WV2 w05pdDJHQmhxLT2vjoRaoSlVHB13wgQlZ1ABQoN2b5Ah4e9/l+w7ntwWzqfXDoP7mBOhFHnN3 w8bghtyF1UvWLKLcA78ZrMGP6StdB9YabkLvSYaIctTE/ohRKJX03g3bPF9aPy/e9b3VU1Gjs TqvJhsg1glvPcnsYJ3w1ik71TrMd7TWRnwWClg6xG8F0L72297VbeAJ7ZmZeMs3pQYrQfiLiY MgFBVvKMxOcM9FcOz2WCBDdz3xb5CoOrm3WnWkQolLGkb85J8zX7xkGaZK6Fh8ZLbShyiNdDB +1Aflz10MbBpzxd/eAzFF1s7+cEufEBgLu1F4lnTq9VohENvV+imqScrBHOMW2ixP8QKfW7V5 6FHwNG3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Omit an extra message for a memory allocation failure in this function. > > The change itself is harmless, but I'm curious about the "extra" > part: "extra" from what? If this happens, hopefully this will be logged > somewhere? Note that this type of (infrequent) logging noise is useful > in some cases, e.g., with 8ce675ff, when one is trying to do the > post-mortem of where things first went wrong. Do you find information from a Linux allocation failure report sufficient for such an use case? Regards, Markus