From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CA4C54EBD for ; Mon, 9 Jan 2023 02:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233601AbjAICQn (ORCPT ); Sun, 8 Jan 2023 21:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbjAICQl (ORCPT ); Sun, 8 Jan 2023 21:16:41 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32018F17; Sun, 8 Jan 2023 18:16:38 -0800 (PST) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NqyG11HcKzJrNH; Mon, 9 Jan 2023 10:15:21 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 9 Jan 2023 10:16:05 +0800 Subject: Re: [PATCH] mce: fix missing stack-dumping in mce_panic() To: "Luck, Tony" CC: "x86@kernel.org" , "hpa@zytor.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , Borislav Petkov References: <20221202163728.392509-1-linmiaohe@huawei.com> <5cf492bf-9807-a091-6ac2-a953fce276da@huawei.com> <1e97c11d-99b6-c06f-b67f-c56ba6653d27@huawei.com> <276c9e6b-d647-6f7f-7bd1-c1f45ca23261@huawei.com> From: Miaohe Lin Message-ID: <1e1bfb2a-5e20-626f-97f7-5ff4cf3d4d51@huawei.com> Date: Mon, 9 Jan 2023 10:16:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/1/9 1:54, Luck, Tony wrote: >> As a first step, let's change the current behavior of no stack dumps first? And then, >> we could try to achieve #1 preference if possible. > > Ok. Repost the patch that fixes things for an oops dump for every mce_panic(). Do you mean make every call site of mce_panic() does a successful oops dump? I think this patch will have achieved that. Or do I miss-read your comment? > > Maybe then I can look at some way to suppress the oops dump for the "useless" > cases? Or perhaps at least add an extra message that stack dumps from arbitrary > machine checks are rarely useful. IMHO the user will always expect a stack dump when system panic. I'm afraid that if these "useless" cases are eliminated, it will cause user confused and trying to find what eats the stack dump? Thanks, Miaohe Lin