From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH v1 1/1] platform/x86: intel_cht_int33fe: Fix comment according to the code flow
Date: Thu, 1 Sep 2022 14:50:36 +0200 [thread overview]
Message-ID: <1e23900b-a1f4-b3b1-8ed5-2b1db6eeb519@redhat.com> (raw)
In-Reply-To: <20220824152115.88012-1-andriy.shevchenko@linux.intel.com>
Hi,
On 8/24/22 17:21, Andy Shevchenko wrote:
> We don't use software_node_register_nodes() in the code, fix the comment.
>
> Fixes: 140355e5db8b ("platform/x86: intel_cht_int33fe: Convert software node array to group")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel/chtwc_int33fe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/chtwc_int33fe.c b/drivers/platform/x86/intel/chtwc_int33fe.c
> index c52ac23e2331..9448e2e67c3f 100644
> --- a/drivers/platform/x86/intel/chtwc_int33fe.c
> +++ b/drivers/platform/x86/intel/chtwc_int33fe.c
> @@ -219,7 +219,7 @@ static int cht_int33fe_add_nodes(struct cht_int33fe_data *data)
>
> /*
> * Update node used in "usb-role-switch" property. Note that we
> - * rely on software_node_register_nodes() to use the original
> + * rely on software_node_register_node_group() to use the original
> * instance of properties instead of copying them.
> */
> fusb302_mux_refs[0].node = mux_ref_node;
prev parent reply other threads:[~2022-09-01 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:21 Andy Shevchenko
2022-08-31 14:16 ` Andy Shevchenko
2022-08-31 15:16 ` Hans de Goede
2022-09-01 12:50 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e23900b-a1f4-b3b1-8ed5-2b1db6eeb519@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®